Commit f6b98e46 authored by Todd Zullinger's avatar Todd Zullinger Committed by Junio C Hamano

git-web--browse: Fix check for /bin/start

The previous check in git-web--browse for /bin/start used test -n
/bin/start, which was always true.  This lead to "start" being tried
first in the browser list.  On systems with upstart installed, "start"
exists and might be in the PATH, but it makes a poor choice for a web
browser.  Instead, test that /bin/start exists and is executable.
Signed-off-by: Todd Zullinger's avatarTodd Zullinger <>
Signed-off-by: default avatarJunio C Hamano <>
parent df487baa
......@@ -115,7 +115,7 @@ if test -z "$browser" ; then
browser_candidates="open $browser_candidates"
# /bin/start indicates MinGW
if test -n /bin/start; then
if test -x /bin/start; then
browser_candidates="start $browser_candidates"
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment