Commit eaa541eb authored by Jeff King's avatar Jeff King Committed by Junio C Hamano

builtin/commit.c: use xstrdup_or_null instead of envdup

The only reason for envdup to be its own function is that we
have to save the result in a temporary string. With
xstrdup_or_null, we can feed the result of getenv()
Signed-off-by: default avatarJeff King <>
Signed-off-by: default avatarJunio C Hamano <>
parent 44406907
......@@ -566,20 +566,14 @@ static void set_ident_var(char **buf, char *val)
*buf = val;
static char *envdup(const char *var)
const char *val = getenv(var);
return val ? xstrdup(val) : NULL;
static void determine_author_info(struct strbuf *author_ident)
char *name, *email, *date;
struct ident_split author;
name = envdup("GIT_AUTHOR_NAME");
email = envdup("GIT_AUTHOR_EMAIL");
date = envdup("GIT_AUTHOR_DATE");
name = xstrdup_or_null(getenv("GIT_AUTHOR_NAME"));
email = xstrdup_or_null(getenv("GIT_AUTHOR_EMAIL"));
date = xstrdup_or_null(getenv("GIT_AUTHOR_DATE"));
if (author_message) {
struct ident_split ident;
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment