Commit d5b0c97d authored by Elijah Newren's avatar Elijah Newren Committed by Junio C Hamano

git-filter-branch: avoid collisions with variables in eval'ed commands

Avoid using simple variable names like 'i', since user commands are eval'ed
and may clash with and overwrite our values.
Signed-off-by: Elijah Newren's avatarElijah Newren <newren@gmail.com>
Acked-by: default avatarPetr Baudis <pasky@suse.cz>
Signed-off-by: default avatarJunio C Hamano <gitster@pobox.com>
parent 8befac5d
......@@ -272,10 +272,10 @@ test $commits -eq 0 && die "Found nothing to rewrite"
# Rewrite the commits
i=0
git_filter_branch__commit_count=0
while read commit parents; do
i=$(($i+1))
printf "\rRewrite $commit ($i/$commits)"
git_filter_branch__commit_count=$(($git_filter_branch__commit_count+1))
printf "\rRewrite $commit ($git_filter_branch__commit_count/$commits)"
case "$filter_subdir" in
"")
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment