Commit 7e7abea9 authored by Dmitry Potapov's avatar Dmitry Potapov Committed by Shawn O. Pearce

print an error message for invalid path

If verification of path failed, it is always better to print an
error message saying this than relying on the caller function to
print a meaningful error message (especially when the callee already
prints error message for another situation).

Because the callers of add_index_entry_with_check() did not print
any error message, it resulted that the user would not notice the
problem when checkout of an invalid path failed.
Signed-off-by: default avatarDmitry Potapov <>
Signed-off-by: default avatarShawn O. Pearce <>
parent 616ab437
......@@ -218,7 +218,7 @@ static int add_cacheinfo(unsigned int mode, const unsigned char *sha1,
struct cache_entry *ce;
if (!verify_path(path))
return -1;
return error("Invalid path '%s'", path);
len = strlen(path);
size = cache_entry_size(len);
......@@ -608,8 +608,10 @@ struct cache_entry *make_cache_entry(unsigned int mode,
int size, len;
struct cache_entry *ce;
if (!verify_path(path))
if (!verify_path(path)) {
error("Invalid path '%s'", path);
return NULL;
len = strlen(path);
size = cache_entry_size(len);
......@@ -893,7 +895,7 @@ static int add_index_entry_with_check(struct index_state *istate, struct cache_e
if (!ok_to_add)
return -1;
if (!verify_path(ce->name))
return -1;
return error("Invalid path '%s'", ce->name);
if (!skip_df_check &&
check_file_directory_conflict(istate, ce, pos, ok_to_replace)) {
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment