Commit 5d176fb6 authored by René Scharfe's avatar René Scharfe Committed by Junio C Hamano

pickaxe: pass diff_options to contains and has_changes

Remove the unused parameter needle from contains() and has_changes().

Also replace the parameter len with a pointer to the diff_options.  We
can use its member pickaxe to check if the needle is an empty string
and use the kwsmatch structure to find out the length of the match
instead.

This change is done as a preparation to unify the signatures of
has_changes() and diff_grep(), which will be used in the patch after
the next one to factor out common code.
Signed-off-by: default avatarRene Scharfe <rene.scharfe@lsrfire.ath.cx>
Signed-off-by: default avatarJunio C Hamano <gitster@pobox.com>
parent 15dafaf8
...@@ -144,14 +144,13 @@ static void diffcore_pickaxe_grep(struct diff_options *o) ...@@ -144,14 +144,13 @@ static void diffcore_pickaxe_grep(struct diff_options *o)
return; return;
} }
static unsigned int contains(struct diff_filespec *one, static unsigned int contains(struct diff_filespec *one, struct diff_options *o,
const char *needle, unsigned long len,
regex_t *regexp, kwset_t kws) regex_t *regexp, kwset_t kws)
{ {
unsigned int cnt; unsigned int cnt;
unsigned long sz; unsigned long sz;
const char *data; const char *data;
if (!len) if (!o->pickaxe[0])
return 0; return 0;
if (diff_populate_filespec(one, 0)) if (diff_populate_filespec(one, 0))
return 0; return 0;
...@@ -175,14 +174,15 @@ static unsigned int contains(struct diff_filespec *one, ...@@ -175,14 +174,15 @@ static unsigned int contains(struct diff_filespec *one,
} else { /* Classic exact string match */ } else { /* Classic exact string match */
while (sz) { while (sz) {
size_t offset = kwsexec(kws, data, sz, NULL); struct kwsmatch kwsm;
size_t offset = kwsexec(kws, data, sz, &kwsm);
const char *found; const char *found;
if (offset == -1) if (offset == -1)
break; break;
else else
found = data + offset; found = data + offset;
sz -= found - data + len; sz -= found - data + kwsm.size[0];
data = found + len; data = found + kwsm.size[0];
cnt++; cnt++;
} }
} }
...@@ -190,20 +190,20 @@ static unsigned int contains(struct diff_filespec *one, ...@@ -190,20 +190,20 @@ static unsigned int contains(struct diff_filespec *one,
return cnt; return cnt;
} }
static int has_changes(struct diff_filepair *p, const char *needle, static int has_changes(struct diff_filepair *p, struct diff_options *o,
unsigned long len, regex_t *regexp, kwset_t kws) regex_t *regexp, kwset_t kws)
{ {
if (!DIFF_FILE_VALID(p->one)) { if (!DIFF_FILE_VALID(p->one)) {
if (!DIFF_FILE_VALID(p->two)) if (!DIFF_FILE_VALID(p->two))
return 0; /* ignore unmerged */ return 0; /* ignore unmerged */
/* created */ /* created */
return contains(p->two, needle, len, regexp, kws) != 0; return contains(p->two, o, regexp, kws) != 0;
} }
if (!DIFF_FILE_VALID(p->two)) if (!DIFF_FILE_VALID(p->two))
return contains(p->one, needle, len, regexp, kws) != 0; return contains(p->one, o, regexp, kws) != 0;
if (!diff_unmodified_pair(p)) { if (!diff_unmodified_pair(p)) {
return contains(p->one, needle, len, regexp, kws) != return contains(p->one, o, regexp, kws) !=
contains(p->two, needle, len, regexp, kws); contains(p->two, o, regexp, kws);
} }
return 0; return 0;
} }
...@@ -241,7 +241,7 @@ static void diffcore_pickaxe_count(struct diff_options *o) ...@@ -241,7 +241,7 @@ static void diffcore_pickaxe_count(struct diff_options *o)
/* Showing the whole changeset if needle exists */ /* Showing the whole changeset if needle exists */
for (i = 0; i < q->nr; i++) { for (i = 0; i < q->nr; i++) {
struct diff_filepair *p = q->queue[i]; struct diff_filepair *p = q->queue[i];
if (has_changes(p, needle, len, regexp, kws)) if (has_changes(p, o, regexp, kws))
goto out; /* do not munge the queue */ goto out; /* do not munge the queue */
} }
...@@ -257,7 +257,7 @@ static void diffcore_pickaxe_count(struct diff_options *o) ...@@ -257,7 +257,7 @@ static void diffcore_pickaxe_count(struct diff_options *o)
/* Showing only the filepairs that has the needle */ /* Showing only the filepairs that has the needle */
for (i = 0; i < q->nr; i++) { for (i = 0; i < q->nr; i++) {
struct diff_filepair *p = q->queue[i]; struct diff_filepair *p = q->queue[i];
if (has_changes(p, needle, len, regexp, kws)) if (has_changes(p, o, regexp, kws))
diff_q(&outq, p); diff_q(&outq, p);
else else
diff_free_filepair(p); diff_free_filepair(p);
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment