Commit 46203ac2 authored by Junio C Hamano's avatar Junio C Hamano

cvsserver: use safe_pipe_capture for `constant commands` as well

This is not strictly necessary, but it is a good code hygiene.
Signed-off-by: 's avatarJunio C Hamano <gitster@pobox.com>
parent 27dd7387
...@@ -356,7 +356,7 @@ sub req_Root ...@@ -356,7 +356,7 @@ sub req_Root
return 0; return 0;
} }
my @gitvars = `git config -l`; my @gitvars = safe_pipe_capture(qw(git config -l));
if ($?) { if ($?) {
print "E problems executing git-config on the server -- this is not a git repository or the PATH is not set correctly.\n"; print "E problems executing git-config on the server -- this is not a git repository or the PATH is not set correctly.\n";
print "E \n"; print "E \n";
...@@ -943,7 +943,7 @@ sub req_co ...@@ -943,7 +943,7 @@ sub req_co
# Provide list of modules, if -c was used. # Provide list of modules, if -c was used.
if (exists $state->{opt}{c}) { if (exists $state->{opt}{c}) {
my $showref = `git show-ref --heads`; my $showref = safe_pipe_capture(qw(git show-ref --heads));
for my $line (split '\n', $showref) { for my $line (split '\n', $showref) {
if ( $line =~ m% refs/heads/(.*)$% ) { if ( $line =~ m% refs/heads/(.*)$% ) {
print "M $1\t$1\n"; print "M $1\t$1\n";
...@@ -1181,7 +1181,7 @@ sub req_update ...@@ -1181,7 +1181,7 @@ sub req_update
# projects (heads in this case) to checkout. # projects (heads in this case) to checkout.
# #
if ($state->{module} eq '') { if ($state->{module} eq '') {
my $showref = `git show-ref --heads`; my $showref = safe_pipe_capture(qw(git show-ref --heads));
print "E cvs update: Updating .\n"; print "E cvs update: Updating .\n";
for my $line (split '\n', $showref) { for my $line (split '\n', $showref) {
if ( $line =~ m% refs/heads/(.*)$% ) { if ( $line =~ m% refs/heads/(.*)$% ) {
...@@ -1687,7 +1687,7 @@ sub req_ci ...@@ -1687,7 +1687,7 @@ sub req_ci
return; return;
} }
my $treehash = `git write-tree`; my $treehash = safe_pipe_capture(qw(git write-tree));
chomp $treehash; chomp $treehash;
$log->debug("Treehash : $treehash, Parenthash : $parenthash"); $log->debug("Treehash : $treehash, Parenthash : $parenthash");
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment