Commit 360af2da authored by Duy Nguyen's avatar Duy Nguyen Committed by Junio C Hamano

worktree.c: rewrite mark_current_worktree() to avoid strbuf

strbuf is a bit overkill for this function. What we need is to call
absolute_path() twice and make sure the second call does not destroy the
result of the first. One buffer allocation is enough.
Signed-off-by: Duy Nguyen's avatarNguyễn Thái Ngọc Duy <>
Reviewed-by: Eric Sunshine's avatarEric Sunshine <>
Signed-off-by: 's avatarJunio C Hamano <>
parent b462c024
......@@ -153,21 +153,19 @@ static struct worktree *get_linked_worktree(const char *id)
static void mark_current_worktree(struct worktree **worktrees)
struct strbuf git_dir = STRBUF_INIT;
struct strbuf path = STRBUF_INIT;
char *git_dir = xstrdup(absolute_path(get_git_dir()));
int i;
strbuf_addstr(&git_dir, absolute_path(get_git_dir()));
for (i = 0; worktrees[i]; i++) {
struct worktree *wt = worktrees[i];
strbuf_addstr(&path, absolute_path(get_worktree_git_dir(wt)));
wt->is_current = !fspathcmp(git_dir.buf, path.buf);
if (wt->is_current)
const char *wt_git_dir = get_worktree_git_dir(wt);
if (!fspathcmp(git_dir, absolute_path(wt_git_dir))) {
wt->is_current = 1;
struct worktree **get_worktrees(void)
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment