Commit 2c49f7ff authored by Duy Nguyen's avatar Duy Nguyen Committed by Junio C Hamano

commit: don't be fooled by ita entries when creating initial commit

ita entries are dropped at tree generation phase. If the entire index
consists of just ita entries, the result would be a a commit with no
entries, which should be caught unless --allow-empty is specified. The
test "!!active_nr" is not sufficient to catch this.
Signed-off-by: Duy Nguyen's avatarNguyễn Thái Ngọc Duy <>
Signed-off-by: default avatarJunio C Hamano <>
parent 018ec3c8
......@@ -894,9 +894,14 @@ static int prepare_to_commit(const char *index_file, const char *prefix,
if (amend)
parent = "HEAD^1";
if (get_sha1(parent, sha1))
commitable = !!active_nr;
else {
if (get_sha1(parent, sha1)) {
int i, ita_nr = 0;
for (i = 0; i < active_nr; i++)
if (ce_intent_to_add(active_cache[i]))
commitable = active_nr - ita_nr > 0;
} else {
* Unless the user did explicitly request a submodule
* ignore mode by passing a command line option we do
......@@ -129,6 +129,16 @@ test_expect_success 'cache-tree does skip dir that becomes empty' '
test_expect_success 'commit: ita entries ignored in empty intial commit check' '
git init empty-intial-commit &&
cd empty-intial-commit &&
: >one &&
git add -N one &&
test_must_fail git commit -m nothing-new-here
test_expect_success 'commit: ita entries ignored in empty commit check' '
git init empty-subsequent-commit &&
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment