Commit 1958a6eb authored by karthik nayak's avatar karthik nayak Committed by Junio C Hamano

ref-filter: make 'ref_array_item' use a FLEX_ARRAY for refname

This would remove the need of using a pointer to store refname.
Mentored-by: Christian Couder's avatarChristian Couder <>
Mentored-by: Matthieu Moy's avatarMatthieu Moy <>
Signed-off-by: karthik nayak's avatarKarthik Nayak <>
Reviewed-by: default avatarMatthieu Moy <>
Signed-off-by: default avatarJunio C Hamano <>
parent 14de7fba
......@@ -847,8 +847,10 @@ static struct ref_array_item *new_ref_array_item(const char *refname,
const unsigned char *objectname,
int flag)
struct ref_array_item *ref = xcalloc(1, sizeof(struct ref_array_item));
ref->refname = xstrdup(refname);
size_t len = strlen(refname);
struct ref_array_item *ref = xcalloc(1, sizeof(struct ref_array_item) + len + 1);
memcpy(ref->refname, refname, len);
ref->refname[len] = '\0';
hashcpy(ref->objectname, objectname);
ref->flag = flag;
......@@ -889,7 +891,6 @@ static int ref_filter_handler(const char *refname, const struct object_id *oid,
static void free_array_item(struct ref_array_item *item)
free((char *)item->symref);
......@@ -32,7 +32,7 @@ struct ref_array_item {
int flag;
const char *symref;
struct atom_value *value;
char *refname;
char refname[FLEX_ARRAY];
struct ref_array {
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment