• Johannes Schindelin's avatar
    legacy stash: fix "rudimentary backport of -q" · 7b556aa4
    Johannes Schindelin authored
    When this developer backported support for `--quiet` to the scripted
    version of `git stash` in 80590055ea (stash: optionally use the scripted
    version again, 2018-12-20), it looked like a sane choice to use `eval`
    to execute the command line passed in via the parameter list of
    `maybe_quiet`.
    
    However, that is not what we should have done, as that command-line was
    already in the correct shape.
    
    This can be seen very clearly when passing arguments with special
    characters, like
    
    	git stash -- ':(glob)**/*.txt'
    
    Since this is exactly what we want to test in the next commit (where we
    fix this very incantation with the built-in stash), let's fix the legacy
    scripted version of `git stash` first.
    Signed-off-by: Johannes Schindelin's avatarJohannes Schindelin <johannes.schindelin@gmx.de>
    Signed-off-by: 's avatarJunio C Hamano <gitster@pobox.com>
    7b556aa4
git-legacy-stash.sh 16 KB