Skip to content
  • Jeff King's avatar
    builtin: consistently pass cmd_* prefix to parse_options · d64db5b3
    Jeff King authored and Junio C Hamano's avatar Junio C Hamano committed
    
    
    If a builtin uses RUN_SETUP to request that git.c enter the repository
    directory, we'll get passed in a "prefix" variable with the path to the
    original directory.  It's important to pass this to parse_options(),
    since we may use it to fix up relative OPT_FILENAME() options. Some
    builtins don't bother; let's make sure we do so consistently.
    
    There may not be any particular bugs fixed here; OPT_FILENAME is
    actually pretty rare, and none of these commands use it directly.
    However, this does future-proof us against somebody adding an option
    that uses it and creating a subtle bug that only shows up when you're in
    a subdirectory of the repository.
    
    In some cases, like hash-object and upload-pack, we don't specify
    RUN_SETUP, so we know the prefix will always be empty. It's still worth
    passing the variable along to keep the idiom consistent across all
    builtins (and of course it protects us if they ever _did_ switch to
    using RUN_SETUP).
    
    Signed-off-by: default avatarJeff King <peff@peff.net>
    Signed-off-by: default avatarJunio C Hamano <gitster@pobox.com>
    d64db5b3