Skip to content
  • Brandon Williams's avatar
    transport: add protocol policy config option · f1762d77
    Brandon Williams authored and Junio C Hamano's avatar Junio C Hamano committed
    
    
    Previously the `GIT_ALLOW_PROTOCOL` environment variable was used to
    specify a whitelist of protocols to be used in clone/fetch/push
    commands.  This patch introduces new configuration options for more
    fine-grained control for allowing/disallowing protocols.  This also has
    the added benefit of allowing easier construction of a protocol
    whitelist on systems where setting an environment variable is
    non-trivial.
    
    Now users can specify a policy to be used for each type of protocol via
    the 'protocol.<name>.allow' config option.  A default policy for all
    unconfigured protocols can be set with the 'protocol.allow' config
    option.  If no user configured default is made git will allow known-safe
    protocols (http, https, git, ssh, file), disallow known-dangerous
    protocols (ext), and have a default policy of `user` for all other
    protocols.
    
    The supported policies are `always`, `never`, and `user`.  The `user`
    policy can be used to configure a protocol to be usable when explicitly
    used by a user, while disallowing it for commands which run
    clone/fetch/push commands without direct user intervention (e.g.
    recursive initialization of submodules).  Commands which can potentially
    clone/fetch/push from untrusted repositories without user intervention
    can export `GIT_PROTOCOL_FROM_USER` with a value of '0' to prevent
    protocols configured to the `user` policy from being used.
    
    Fix remote-ext tests to use the new config to allow the ext
    protocol to be tested.
    
    Based on a patch by Jeff King <peff@peff.net>
    
    Signed-off-by: default avatarBrandon Williams <bmwill@google.com>
    Signed-off-by: default avatarJunio C Hamano <gitster@pobox.com>
    f1762d77