Skip to content
  • Jeff King's avatar
    http-push: stop using name_path · c6bd2a1d
    Jeff King authored and Junio C Hamano's avatar Junio C Hamano committed
    The graph traversal code here passes along a name_path to
    build up the pathname at which we find each blob. But we
    never actually do anything with the resulting names, making
    it a waste of code and memory.
    
    This usage came in aa1dbc98 (Update http-push functionality,
    2006-03-07), and originally the result was passed to
    "add_object" (which stored it, but didn't really use it,
    either). But we stopped using that function in 1f1e895f
    
     (Add
    "named object array" concept, 2006-06-19) in favor of
    storing just the objects themselves.
    
    Moreover, the generation of the name in process_tree() is
    buggy. It sticks "name" onto the end of the name_path linked
    list, and then passes it down again as it recurses (instead
    of "entry.path"). So it's a good thing this was unused, as
    the resulting path for "a/b/c/d" would end up as "a/a/a/a".
    
    Signed-off-by: default avatarJeff King <peff@peff.net>
    Signed-off-by: default avatarJunio C Hamano <gitster@pobox.com>
    c6bd2a1d