Skip to content
  • Junio C Hamano's avatar
    merge: avoid "safer crlf" during recording of merge results · 1335d76e
    Junio C Hamano authored
    
    
    When merge_recursive() decides what the correct blob object merge
    result for a path should be, it uses update_file_flags() helper
    function to write it out to a working tree file and then calls
    add_cacheinfo().  The add_cacheinfo() function in turn calls
    make_cache_entry() to create a new cache entry to replace the
    higher-stage entries for the path that represents the conflict.
    
    The make_cache_entry() function calls refresh_cache_entry() to fill
    in the cached stat information.  To mark a cache entry as
    up-to-date, the data is re-read from the file in the working tree,
    and goes through convert_to_git() conversion to be compared with the
    blob object name the new cache entry records.
    
    It is important to note that this happens while the higher-stage
    entries, which are going to be replaced with the new entry, are
    still in the index.  Unfortunately, the convert_to_git() conversion
    has a misguided "safer crlf" mechanism baked in, and looks at the
    existing cache entry for the path to decide how to convert the
    contents in the working tree file.  If our side (i.e. stage#2)
    records a text blob with CRLF in it, even when the system is
    configured to record LF in blobs and convert them to CRLF upon
    checkout (and back to LF upon checkin), the "safer crlf" mechanism
    stops us doing so.
    
    This especially poses a problem during a renormalizing merge, where
    the merge result for the path is computed by first "normalizing" the
    blobs involved in the merge by using convert_to_working_tree()
    followed by convert_to_git() with "safer crlf" disabled.  The merge
    result that is computed correctly and fed to add_cacheinfo() via
    update_file_flags() does _not_ match what refresh_cache_entry() sees
    by converting the working tree file via convert_to_git().
    
    We can work this around by not refreshing the new cache entry in
    make_cache_entry() called by add_cacheinfo().  After add_cacheinfo()
    adds the new entry, we can call refresh_cache_entry() on that,
    knowing that addition of this new cache entry would have removed the
    stale cache entries that had CRLF in stage #2 that were carried over
    before the renormalizing merge started and will not interfere with
    the correct recording of the result.
    
    The test update was taken from a series by Torsten Bögershausen
    that attempted to fix this with a different approach.
    
    Signed-off-by: default avatarTorsten Bögershausen <tboegi@web.de>
    Signed-off-by: default avatarJunio C Hamano <gitster@pobox.com>
    Reviewed-by: default avatarTorsten Bögershausen <tboegi@web.de>
    1335d76e