• Jeff King's avatar
    parse-options: print "fatal:" before usage_msg_opt() · 87433261
    Jeff King authored
    Programs may use usage_msg_opt() to print a brief message
    followed by the program usage, and then exit. The message
    isn't prefixed at all, though, so it doesn't match our usual
    error output and is easy to overlook:
        $ git clone 1 2 3
        Too many arguments.
        usage: git clone [<options>] [--] <repo> [<dir>]
        -v, --verbose         be more verbose
        -q, --quiet           be more quiet
        --progress            force progress reporting
        -n, --no-checkout     don't create a checkout
        --bare                create a bare repository
        [...and so on for another 31 lines...]
    It looks especially bad when the message starts with an
    option, like:
        $ git replace -e
        -e needs exactly one argument
        usage: git replace [-f] <object> <replacement>
           or: git replace [-f] --edit <object>
    Let's put our usual "fatal:" prefix in front of it.
    Signed-off-by: default avatarJeff King <peff@peff.net>
    Signed-off-by: default avatarJunio C Hamano <gitster@pobox.com>
parse-options.c 17.4 KB