• Jeff King's avatar
    use xmallocz to avoid size arithmetic · 3733e694
    Jeff King authored
    We frequently allocate strings as xmalloc(len + 1), where
    the extra 1 is for the NUL terminator. This can be done more
    simply with xmallocz, which also checks for integer
    There's no case where switching xmalloc(n+1) to xmallocz(n)
    is wrong; the result is the same length, and malloc made no
    guarantees about what was in the buffer anyway. But in some
    cases, we can stop manually placing NUL at the end of the
    allocated buffer. But that's only safe if it's clear that
    the contents will always fill the buffer.
    In each case where this patch does so, I manually examined
    the control flow, and I tried to err on the side of caution.
    Signed-off-by: default avatarJeff King <peff@peff.net>
    Signed-off-by: default avatarJunio C Hamano <gitster@pobox.com>
column.c 9.71 KB