• Duy Nguyen's avatar
    dir.c: ignore paths containing .git when invalidating untracked cache · 0cacebf0
    Duy Nguyen authored
    read_directory() code ignores all paths named ".git" even if it's not
    a valid git repository. See treat_path() for details. Since ".git" is
    basically invisible to read_directory(), when we are asked to
    invalidate a path that contains ".git", we can safely ignore it
    because the slow path would not consider it anyway.
    This helps when fsmonitor is used and we have a real ".git" repo at
    worktree top. Occasionally .git/index will be updated and if the
    fsmonitor hook does not filter it, untracked cache is asked to
    invalidate the path ".git/index".
    Without this patch, we invalidate the root directory unncessarily,
    - makes read_directory() fall back to slow path for root directory
    - makes the index dirty (because UNTR extension is updated). Depending
      on the index size, writing it down could also be slow.
    A note about the new "safe_path" knob. Since this new check could be
    relatively expensive, avoid it when we know it's not needed. If the
    path comes from the index, it can't contain ".git". If it does
    contain, we may be screwed up at many more levels, not just this one.
    Noticed-by: Ævar Arnfjörð Bjarmason's avatarÆvar Arnfjörð Bjarmason <avarab@gmail.com>
    Signed-off-by: Duy Nguyen's avatarNguyễn Thái Ngọc Duy <pclouds@gmail.com>
    Signed-off-by: default avatarJunio C Hamano <gitster@pobox.com>
fsmonitor.c 7.09 KB