• Johannes Schindelin's avatar
    mingw: fix isatty() after dup2() · ff8978d5
    Johannes Schindelin authored
    Since a9b8a09c (mingw: replace isatty() hack, 2016-12-22), we handle
    isatty() by special-casing the stdin/stdout/stderr file descriptors,
    caching the return value. However, we missed the case where dup2()
    overrides the respective file descriptor.
    
    That poses a problem e.g. where the `show` builtin asks for a pager very
    early, the `setup_pager()` function sets the pager depending on the
    return value of `isatty()` and then redirects stdout. Subsequently,
    `cmd_log_init_finish()` calls `setup_pager()` *again*. What should
    happen now is that `isatty()` reports that stdout is *not* a TTY and
    consequently stdout should be left alone.
    
    Let's override dup2() to handle this appropriately.
    
    This fixes https://github.com/git-for-windows/git/issues/1077Signed-off-by: Johannes Schindelin's avatarJohannes Schindelin <johannes.schindelin@gmx.de>
    Signed-off-by: default avatarJunio C Hamano <gitster@pobox.com>
    ff8978d5
winansi.c 16 KB