Skip to content
  • Junio C Hamano's avatar
    merge: refuse to create too cool a merge by default · e379fdf3
    Junio C Hamano authored
    
    
    While it makes sense to allow merging unrelated histories of two
    projects that started independently into one, in the way "gitk" was
    merged to "git" itself aka "the coolest merge ever", such a merge is
    still an unusual event.	 Worse, if somebody creates an independent
    history by starting from a tarball of an established project and
    sends a pull request to the original project, "git merge" however
    happily creates such a merge without any sign of something unusual
    is happening.
    
    Teach "git merge" to refuse to create such a merge by default,
    unless the user passes a new "--allow-unrelated-histories" option to
    tell it that the user is aware that two unrelated projects are
    merged.
    
    Because such a "two project merge" is a rare event, a configuration
    option to always allow such a merge is not added.
    
    We could add the same option to "git pull" and have it passed
    through to underlying "git merge".  I do not have a fundamental
    opposition against such a feature, but this commit does not do so
    and instead leaves it as low-hanging fruit for others, because such
    a "two project merge" would be done after fetching the other project
    into some location in the working tree of an existing project and
    making sure how well they fit together, it is sufficient to allow a
    local merge without such an option pass-through from "git pull" to
    "git merge".  Many tests that are updated by this patch does the
    pass-through manually by turning:
    
    	git pull something
    
    into its equivalent:
    
    	git fetch something &&
    	git merge --allow-unrelated-histories FETCH_HEAD
    
    If somebody is inclined to add such an option, updated tests in this
    change need to be adjusted back to:
    
    	git pull --allow-unrelated-histories something
    
    Signed-off-by: default avatarJunio C Hamano <gitster@pobox.com>
    e379fdf3