• Jeff King's avatar
    date: use strbufs in date-formatting functions · c33ddc2e
    Jeff King authored
    Many of the date functions write into fixed-size buffers.
    This is a minor pain, as we have to take special
    precautions, and frequently end up copying the result into a
    strbuf or heap-allocated buffer anyway (for which we
    sometimes use strcpy!).
    Let's instead teach parse_date, datestamp, etc to write to a
    strbuf. The obvious downside is that we might need to
    perform a heap allocation where we otherwise would not need
    to. However, it turns out that the only two new allocations
    required are:
      1. In test-date.c, where we don't care about efficiency.
      2. In determine_author_info, which is not performance
         critical (and where the use of a strbuf will help later
    Signed-off-by: default avatarJeff King <peff@peff.net>
    Signed-off-by: default avatarJunio C Hamano <gitster@pobox.com>
test-date.c 1.46 KB