Skip to content
  • Martin Ågren's avatar
    config: respect `pager.config` in list/get-mode only · 32888b8f
    Martin Ågren authored and Junio C Hamano's avatar Junio C Hamano committed
    Similar to de121ffe
    
     (tag: respect `pager.tag` in list-mode only,
    2017-08-02), use the DELAY_PAGER_CONFIG-mechanism to only respect
    `pager.config` when we are listing or "get"ing config.
    
    We have several getters and some are guaranteed to give at most one line
    of output. Paging all getters including those could be convenient from a
    documentation point-of-view. The downside would be that a misconfigured
    or not so modern pager might wait for user interaction before
    terminating. Let's instead respect the config for precisely those
    getters which may produce more than one line of output.
    
    `--get-urlmatch` may or may not produce multiple lines of output,
    depending on the exact usage. Let's not try to recognize the two modes,
    but instead make `--get-urlmatch` always respect the config. Analyzing
    the detailed usage might be trivial enough here, but could establish a
    precedent that we will never be able to enforce throughout the codebase
    and that will just open a can of worms.
    
    This fixes the failing test added in the previous commit. Also adapt the
    test for whether `git config foo.bar bar` and `git config --get foo.bar`
    respects `pager.config`.
    
    Signed-off-by: default avatarMartin Ågren <martin.agren@gmail.com>
    Signed-off-by: default avatarJunio C Hamano <gitster@pobox.com>
    32888b8f