Skip to content
  • Jeff King's avatar
    sha1_file: drop free_pack_by_name · 3157c880
    Jeff King authored and Junio C Hamano's avatar Junio C Hamano committed
    The point of this function is to drop an entry from the
    "packed_git" cache that points to a file we might be
    overwriting, because our contents may not be the same (and
    hence the only caller was pack-objects as it moved a
    temporary packfile into place).
    
    In older versions of git, this could happen because the
    names of packfiles were derived from the set of objects they
    contained, not the actual bits on disk. But since 1190a1ac
    
    
    (pack-objects: name pack files after trailer hash,
    2013-12-05), the name reflects the actual bits on disk, and
    any two packfiles with the same name can be used
    interchangeably.
    
    Dropping this function not only saves a few lines of code,
    it makes the lifetime of "struct packed_git" much easier to
    reason about: namely, we now do not ever free these structs.
    
    Signed-off-by: default avatarJeff King <peff@peff.net>
    Signed-off-by: default avatarJunio C Hamano <gitster@pobox.com>
    3157c880