Skip to content
  • Junio C Hamano's avatar
    i18n of multi-line advice messages · 23cb5bf3
    Junio C Hamano authored
    
    
    Advice messages are by definition meant for human end-users, and prime
    candidates for i18n/l10n. They tend to also be more verbose to be helpful,
    and need to be longer than just one line.
    
    Although we do not have parameterized multi-line advice messages yet, once
    we do, we cannot emit such a message like this:
    
        advise(_("Please rename %s to something else"), gostak);
        advise(_("so that we can avoid distimming %s unnecessarily."), doshes);
    
    because some translations may need to have the replacement of 'gostak' on
    the second line (or 'doshes' on the first line). Some languages may even
    need to use three lines in order to fit the same message within a
    reasonable width.
    
    Instead, it has to be a single advise() construct, like this:
    
        advise(_("Please rename %s to something else\n"
                 "so that we can avoid distimming %s unnecessarily."),
               gostak, doshes);
    
    Update the advise() function and its existing callers to
    
     - take a format string that can be multi-line and translatable as a
       whole;
     - use the string and the parameters to form a localized message; and
     - show each line in the result with the localization of the "hint: ".
    
    Signed-off-by: default avatarJunio C Hamano <gitster@pobox.com>
    23cb5bf3