Commit dc2ed04c authored by Junio C Hamano's avatar Junio C Hamano

Merge branch 'bc/http-keep-memory-given-to-curl'

Older cURL wanted piece of memory we call it with to be stable, but
we updated the auth material after handing it to a call.

* bc/http-keep-memory-given-to-curl:
  http.c: don't rewrite the user:passwd string multiple times
parents 9df9bdda a94cf2cb
......@@ -228,9 +228,15 @@ static void init_curl_http_auth(CURL *result)
static struct strbuf up = STRBUF_INIT;
strbuf_addf(&up, "%s:%s",
http_auth.username, http_auth.password);
* Note that we assume we only ever have a single set of
* credentials in a given program run, so we do not have
* to worry about updating this buffer, only setting its
* initial value.
if (!up.len)
strbuf_addf(&up, "%s:%s",
http_auth.username, http_auth.password);
curl_easy_setopt(result, CURLOPT_USERPWD, up.buf);
Markdown is supported
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment