Commit bb84735c authored by René Scharfe's avatar René Scharfe Committed by Junio C Hamano

hex: make wraparound of the index into ring-buffer explicit

Overflow is defined for unsigned integers, but not for signed ones.

We could make the ring-buffer index in sha1_to_hex() and
get_pathname() unsigned to be on the safe side to resolve this, but
let's make it explicit that we are wrapping around at whatever the
number of elements the ring-buffer has.  The compiler is smart enough
to turn modulus into bitmask for these codepaths that use
ring-buffers of a size that is a power of 2.
Signed-off-by: default avatarRené Scharfe <[email protected]>
Signed-off-by: default avatarJunio C Hamano <[email protected]>
parent 23415c26
......@@ -78,7 +78,8 @@ char *sha1_to_hex(const unsigned char *sha1)
static int bufno;
static char hexbuffer[4][GIT_SHA1_HEXSZ + 1];
return sha1_to_hex_r(hexbuffer[3 & ++bufno], sha1);
bufno = (bufno + 1) % ARRAY_SIZE(hexbuffer);
return sha1_to_hex_r(hexbuffer[bufno], sha1);
char *oid_to_hex(const struct object_id *oid)
......@@ -24,7 +24,8 @@ static struct strbuf *get_pathname(void)
static int index;
struct strbuf *sb = &pathname_array[3 & ++index];
struct strbuf *sb = &pathname_array[index];
index = (index + 1) % ARRAY_SIZE(pathname_array);
return sb;
Markdown is supported
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment