Commit a22347c6 authored by Christian Couder's avatar Christian Couder Committed by Junio C Hamano

bisect: rework some rev related functions to make them more reusable

This patches changes the "bisect_rev_setup" and "bisect_common"
functions to make it easier to reuse them in a later patch.
Signed-off-by: Christian Couder's avatarChristian Couder <[email protected]>
Signed-off-by: default avatarJunio C Hamano <[email protected]>
parent 0871984d
......@@ -553,7 +553,9 @@ struct commit_list *filter_skipped(struct commit_list *list,
return filtered;
static void bisect_rev_setup(struct rev_info *revs, const char *prefix)
static void bisect_rev_setup(struct rev_info *revs, const char *prefix,
const char *bad_format, const char *good_format,
int read_paths)
struct argv_array rev_argv = { NULL, 0, 0 };
int i;
......@@ -564,26 +566,24 @@ static void bisect_rev_setup(struct rev_info *revs, const char *prefix)
/* rev_argv.argv[0] will be ignored by setup_revisions */
argv_array_push(&rev_argv, xstrdup("bisect_rev_setup"));
argv_array_push_sha1(&rev_argv, current_bad_sha1, "%s");
argv_array_push_sha1(&rev_argv, current_bad_sha1, bad_format);
for (i = 0; i < good_revs.sha1_nr; i++)
argv_array_push_sha1(&rev_argv, good_revs.sha1[i], "^%s");
argv_array_push_sha1(&rev_argv, good_revs.sha1[i],
argv_array_push(&rev_argv, xstrdup("--"));
if (read_paths)
argv_array_push(&rev_argv, NULL);
setup_revisions(rev_argv.argv_nr, rev_argv.argv, revs, NULL);
revs->limited = 1;
static void bisect_common(struct rev_info *revs, int *reaches, int *all)
static void bisect_common(struct rev_info *revs)
if (prepare_revision_walk(revs))
die("revision walk setup failed");
if (revs->tree_objects)
mark_edges_uninteresting(revs->commits, revs, NULL);
revs->commits = find_bisection(revs->commits, reaches, all,
static void exit_if_skipped_commits(struct commit_list *tried,
......@@ -843,10 +843,13 @@ int bisect_next_all(const char *prefix)
bisect_rev_setup(&revs, prefix);
bisect_rev_setup(&revs, prefix, "%s", "^%s", 1); = 1;
bisect_common(&revs, &reaches, &all);
revs.commits = find_bisection(revs.commits, &reaches, &all,
revs.commits = filter_skipped(revs.commits, &tried, 0);
if (!revs.commits) {
Markdown is supported
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment