Commit a02b8bc4 authored by Romain Picard's avatar Romain Picard Committed by Junio C Hamano

git-p4.py: add support for filetype change

After changing the type of a file in the git repository, it is not possible to
"git p4 publish" the commit to perforce. This is due to the fact that the git
"T" status is not handled in git-p4.py. This can typically occur when replacing
an existing file with a symbolic link.

The "T" modifier is now supported in git-p4.py. When a file type has changed,
inform perforce with the "p4 edit -f auto" command.
Signed-off-by: Romain Picard's avatarRomain Picard <[email protected]>
Acked-by: Luke Diamand's avatarLuke Diamand <[email protected]>
Signed-off-by: default avatarJunio C Hamano <[email protected]>
parent 1b0b6dd0
......@@ -253,8 +253,8 @@ def p4_add(f):
def p4_delete(f):
p4_system(["delete", wildcard_encode(f)])
def p4_edit(f):
p4_system(["edit", wildcard_encode(f)])
def p4_edit(f, *options):
p4_system(["edit"] + list(options) + [wildcard_encode(f)])
def p4_revert(f):
p4_system(["revert", wildcard_encode(f)])
......@@ -1554,6 +1554,7 @@ def applyCommit(self, id):
diff = read_pipe_lines("git diff-tree -r %s \"%s^\" \"%s\"" % (self.diffOpts, id, id))
filesToAdd = set()
filesToChangeType = set()
filesToDelete = set()
editedFiles = set()
pureRenameCopy = set()
......@@ -1614,6 +1615,8 @@ def applyCommit(self, id):
os.unlink(dest)
filesToDelete.add(src)
editedFiles.add(dest)
elif modifier == "T":
filesToChangeType.add(path)
else:
die("unknown modifier %s for %s" % (modifier, path))
......@@ -1673,6 +1676,8 @@ def applyCommit(self, id):
#
system(applyPatchCmd)
for f in filesToChangeType:
p4_edit(f, "-t", "auto")
for f in filesToAdd:
p4_add(f)
for f in filesToDelete:
......
#!/bin/sh
test_description='git p4 support for file type change'
. ./lib-git-p4.sh
test_expect_success 'start p4d' '
start_p4d
'
test_expect_success 'create files' '
(
cd "$cli" &&
p4 client -o | sed "/LineEnd/s/:.*/:unix/" | p4 client -i &&
cat >file1 <<-EOF &&
text without any funny substitution business
EOF
cat >file2 <<-EOF &&
second file whose type will change
EOF
p4 add file1 file2 &&
p4 submit -d "add files"
)
'
test_expect_success SYMLINKS 'change file to symbolic link' '
git p4 clone --dest="$git" //[email protected] &&
test_when_finished cleanup_git &&
(
cd "$git" &&
git config git-p4.skipSubmitEdit true &&
rm file2 &&
ln -s file1 file2 &&
git add file2 &&
git commit -m "symlink file1 to file2" &&
git p4 submit &&
p4 filelog -m 1 //depot/file2 >filelog &&
grep "(symlink)" filelog
)
'
test_expect_success SYMLINKS 'change symbolic link to file' '
git p4 clone --dest="$git" //[email protected] &&
test_when_finished cleanup_git &&
(
cd "$git" &&
git config git-p4.skipSubmitEdit true &&
rm file2 &&
cat >file2 <<-EOF &&
This is another content for the second file.
EOF
git add file2 &&
git commit -m "re-write file2" &&
git p4 submit &&
p4 filelog -m 1 //depot/file2 >filelog &&
grep "(text)" filelog
)
'
test_expect_success 'kill p4d' '
kill_p4d
'
test_done
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment