Commit 84d938b7 authored by Committed by Junio C Hamano
add: do not accept pathspec magic 'attr'
Commit b0db7046 (pathspec: allow querying for attributes - 2017-03-13) adds new pathspec magic 'attr' but only with match_pathspec(). "git add" has some pathspec related code that still does not know about 'attr' and will bail out: $ git add ':(attr:foo)' fatal: BUG:dir.c:1584: unsupported magic 40 A better solution would be making this code support 'attr'. But I don't know how much work is needed (I'm not familiar with this new magic). For now, let's simply reject this magic with a friendlier message: $ git add ':(attr:foo)' fatal: :(attr:foo): pathspec magic not supported by this command: 'attr' Update t6135 so that the expected error message is from the "graceful" rejection codepath, not "oops, we were supposed to reject the request to trigger this magic" codepath. Reported-by: firstname.lastname@example.org Signed-off-by: Nguyễn Thái Ngọc Duy <email@example.com> Signed-off-by: Junio C Hamano <firstname.lastname@example.org>
Showing with 2 additions and 2 deletions