Skip to content
  • Junio C Hamano's avatar
    parse_date_basic(): let the system handle DST conversion · f6e63621
    Junio C Hamano authored
    
    
    The function parses the input to compute the broken-down time in
    "struct tm", and the GMT timezone offset.  If the timezone offset
    does not exist in the input, the broken-down time is turned into the
    number of seconds since epoch both in the current timezone and in
    GMT and the offset is computed as their difference.
    
    However, we forgot to make sure tm.tm_isdst is set to -1 (i.e. let
    the system figure out if DST is in effect in the current timezone
    when turning the broken-down time to the number of seconds since
    epoch); it is done so at the beginning of the function, but a call
    to match_digit() in the function can lead to a call to gmtime_r() to
    clobber the field.
    
    Reported-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
    Diagnosed-by: default avatarEric Sunshine <sunshine@sunshineco.com>
    Signed-off-by: default avatarJunio C Hamano <gitster@pobox.com>
    f6e63621