• Jeff King's avatar
    list-objects: pass full pathname to callbacks · 2824e184
    Jeff King authored
    When we find a blob at "a/b/c", we currently pass this to
    our show_object_fn callbacks as two components: "a/b/" and
    "c". Callbacks which want the full value then call
    path_name(), which concatenates the two. But this is an
    inefficient interface; the path is a strbuf, and we could
    simply append "c" to it temporarily, then roll back the
    length, without creating a new copy.
    So we could improve this by teaching the callsites of
    path_name() this trick (and there are only 3). But we can
    also notice that no callback actually cares about the
    broken-down representation, and simply pass each callback
    the full path "a/b/c" as a string. The callback code becomes
    even simpler, then, as we do not have to worry about freeing
    an allocated buffer, nor rolling back our modification to
    the strbuf.
    This is theoretically less efficient, as some callbacks
    would not bother to format the final path component. But in
    practice this is not measurable. Since we use the same
    strbuf over and over, our work to grow it is amortized, and
    we really only pay to memcpy a few bytes.
    Signed-off-by: default avatarJeff King <[email protected]>
    Signed-off-by: default avatarJunio C Hamano <[email protected]>
list-objects.c 6.02 KB