• Jeff King's avatar
    read-cache: optionally disallow HFS+ .git variants · a42643aa
    Jeff King authored
    The point of disallowing ".git" in the index is that we
    would never want to accidentally overwrite files in the
    repository directory. But this means we need to respect the
    filesystem's idea of when two paths are equal. The prior
    commit added a helper to make such a comparison for HFS+;
    let's use it in verify_path.
    We make this check optional for two reasons:
      1. It restricts the set of allowable filenames, which is
         unnecessary for people who are not on HFS+. In practice
         this probably doesn't matter, though, as the restricted
         names are rather obscure and almost certainly would
         never come up in practice.
      2. It has a minor performance penalty for every path we
         insert into the index.
    This patch ties the check to the core.protectHFS config
    option. Though this is expected to be most useful on OS X,
    we allow it to be set everywhere, as HFS+ may be mounted on
    other platforms. The variable does default to on for OS X,
    Signed-off-by: default avatarJeff King <[email protected]>
    Signed-off-by: default avatarJunio C Hamano <[email protected]>
config.mak.uname 15.3 KB