Skip to content
  • Clemens Buchacher's avatar
    ls-files: fix pathspec display on error · 0f64bfa9
    Clemens Buchacher authored and Junio C Hamano's avatar Junio C Hamano committed
    
    
    The following sequence of commands reveals an issue with error
    reporting of relative paths:
    
     $ mkdir sub
     $ cd sub
     $ git ls-files --error-unmatch ../bbbbb
     error: pathspec 'b' did not match any file(s) known to git.
     $ git commit --error-unmatch ../bbbbb
     error: pathspec 'b' did not match any file(s) known to git.
    
    This bug is visible only if the normalized path (i.e., the relative
    path from the repository root) is longer than the prefix.
    Otherwise, the code skips over the normalized path and reads from
    an unused memory location which still contains a leftover of the
    original command line argument.
    
    So instead, use the existing facilities to deal with relative paths
    correctly.
    
    Also fix inconsistency between "checkout" and "commit", e.g.
    
        $ cd Documentation
        $ git checkout nosuch.txt
        error: pathspec 'Documentation/nosuch.txt' did not match...
        $ git commit nosuch.txt
        error: pathspec 'nosuch.txt' did not match...
    
    by propagating the prefix down the codepath that reports the error.
    
    Signed-off-by: default avatarClemens Buchacher <drizzd@aon.at>
    Signed-off-by: default avatarJunio C Hamano <gitster@pobox.com>
    0f64bfa9