Skip to content
  • Johannes Sixt's avatar
    recv_sideband: Bands #2 and #3 always go to stderr · 34df8aba
    Johannes Sixt authored and Junio C Hamano's avatar Junio C Hamano committed
    
    
    This removes the last parameter of recv_sideband, by which the callers
    told which channel bands #2 and #3 should be written to.
    
    Sayeth Shawn Pearce:
    
       The definition of the streams in the current sideband protocol
       are rather well defined for the one protocol that uses it,
       fetch-pack/receive-pack:
    
         stream #1:  pack data
         stream #2:  stderr messages, progress, meant for tty
         stream #3:  abort message, remote is dead, goodbye!
    
    Since both callers of the function passed 2 for the parameter, we hereby
    remove it and send bands #2 and #3 to stderr explicitly using fprintf.
    
    This has the nice side-effect that these two streams pass through our
    ANSI emulation layer on Windows.
    
    Signed-off-by: default avatarJohannes Sixt <j6t@kdbg.org>
    Acked-by: default avatarNicolas Pitre <nico@cam.org>
    Signed-off-by: default avatarJunio C Hamano <gitster@pobox.com>
    34df8aba