Skip to content

Sentry

David Burke requested to merge sentry into dev

passit#77 (closed)

What is this

This adds sentry error reporting to passit frontend and a settings page to change the opt in status

How

The backend now accepts PATCH requests for the user rest endpoint and has a new opt in error reporting boolean. This MR has to do a few things

  • There is a settings page under account to change the status. It should load your current opt in status and allow you to change it. I called it Error Reporting but I had in mind this could become a full preferences page in the future.
  • Getting sentry set up is complex. Typically in sentry we prepare the DSN (where to report) immediately. Unfortunately we can't do that because we have to ask the server what the DSN even is and we have to ask the server if the user wishes to opt in. Thus the sentry set up is delayed. It can however save state on disk, making it a little faster sometimes to get set up.
  • Getting user opt in status doesn't happen often. (room for improvement?) When the user logs in or changes the status it will update. We probably need to think holistically about the user changing something on another device. So out of scope I guess.

What to test

  • Server defaults to opt in vs opt out
  • User registers/login with opt in/out (this can change on register because of server defaults)
  • Does sentry actually capture errors? Given the delay on configuration what concerns exist about the app erroring before set up. Are we missing important init errors because of this? Could that be mitigated?
  • Does error reporting happen only when user opts in.
  • Refreshing page with "remember log in" vs not saving to disk.
Edited by David Burke

Merge request reports