DESTDIR not used by PASSWORD_STORE_EXTENSIONS_INSTALL_DIR
Summary
This one might be related to #4:
While creating a PKGBUILD file for creating an ArchLinux (AUR) package for this tool, I noticed the following problem:
- In order for making it work, the DESTDIR variable needs to be set to a subfolder of the package "pkg/" directory.
- This does not seem to be taken up by the line declaring
PASSWORD_STORE_EXTENSIONS_INSTALL_DIR
.
The following patch (for the Makefile) resolved it for me:
--- src/pass-team/Makefile.orig 2024-05-13 17:23:09.503362641 +0200
+++ Makefile 2024-05-14 15:26:56.555541055 +0200
@@ -42,7 +42,7 @@
PASSWORD_STORE_EXECUTABLE ?= $(shell command -v pass || true)
ifneq ($(PASSWORD_STORE_EXECUTABLE),)
-PASSWORD_STORE_EXTENSIONS_INSTALL_DIR ?= $(shell cat "$(PASSWORD_STORE_EXECUTABLE)" | grep "SYSTEM_EXTENSION_DIR=" | sed 's/SYSTEM_EXTENSION_DIR="\(.*\)"/\1/')
+PASSWORD_STORE_EXTENSIONS_INSTALL_DIR ?= $(addprefix $(DESTDIR),$(shell cat "$(PASSWORD_STORE_EXECUTABLE)" | grep "SYSTEM_EXTENSION_DIR=" | sed 's/SYSTEM_EXTENSION_DIR="\(.*\)"/\1/'))
endif
.PHONY: installcheck
Expected Behavior
Installation of the extension into a subfolder set by the DESTDIR variable.
Actual Behavior
An error message indicating, that the DESTDIR was not used as a prefix for the extension.
Steps to Reproduce the Problem
- set DESTDIR to something accessible by the current user.
- run
make install
Specifications
- Pass Team Version: 0.1.0-rc.11+f-key-mgmt
- Pass Version: v1.7.4
- Installation Method: git + Makefile
- Platform: ArchLinux
Possible fixes
See above, use the patch before running make install
.