Couple of changes
Hi - thanks for continuing to work on this project. I've got a couple of comments that hopefully you'll find useful.
-
scanner/Geonames.py I get an error on my system (fully updated archlinux) that 'import requests' fails as no such module My fix is to simply delete the import line. It would also be useful to make geonames config optional to turn on/off.
-
scanner/PhotoAlbum.py Makes the hard coded assumption that exiftool is available. Regardless of the setting of metadata_tools_preference variable in the config file. (mine is set to ['PIL']. This causes failure when exiftool is not installed. I just commented this code out - I'm sure you can find a more elegant solution.
-
sbin/js-css-minify.sh Please add support for rcssmin - I do not have cssmin available. This simple patch adds support for rcssmin.
--- js-css-minify.sh 2019-02-22 10:02:10.540402670 -0500
+++ js-css-minify-1.sh 2019-02-21 21:22:33.720915567 -0500
@@ -109,6 +109,14 @@
exit 1
fi
;;
+ rcssmin)
+ python -mrcssmin < /dev/null
+ if [ $? -ne 0 ]; then
+ ( >&2 echo "'rcssmin' is not installed.'" )
+ ( >&2 echo "Aborting..." )
+ exit 1
+ fi
+ ;;
esac
# minify all .js-files
@@ -225,6 +233,10 @@
cssmin < $cssfile > $newfile
;;
+ rcssmin)
+ python -mrcssmin < $cssfile > $newfile
+ ;;
+
*)
( >&2 echo "Unsupported CSS minifier: $MINIFY_CSS. Check option 'css_minifier' in '$CONF'" )
( >&2 echo "Doing nothing on file $cssfile" )
Thanks!