Commit 5e358bca authored by krlwlfrt's avatar krlwlfrt
Browse files

fix: remove undocumented default params

parent 0ca6af82
Loading
Loading
Loading
Loading
+14 −15
Original line number Diff line number Diff line
@@ -301,29 +301,28 @@ export class Api {
   *
   * @param options Options to get issues
   */
  public getIssues(options?: ApiGetIssuesOptions): Promise<Issue[]> {
    // set 'Meeting' as default milestone
    const _options: ApiGetIssuesOptions = {
      ...{
        milestone: 'Meeting',
      },
      ...options,
    };

  public getIssues(options: ApiGetIssuesOptions = {}): Promise<Issue[]> {
    // start to build request url
    let requestUrl = 'issues';

    // set initial divider for filter params
    let divider = '?';

    // request issues only for specific group, if group ID is set
    if (typeof _options.groupId === 'number') {
      requestUrl = 'groups/' + _options.groupId + '/' + requestUrl;
    if (typeof options.groupId === 'number') {
      requestUrl = `groups/${options.groupId}/requestUrl`;
    }

    if (typeof options.milestone === 'string') {
      // add milestone to request url
    requestUrl += '?milestone=' + _options.milestone;
      requestUrl += `${divider}milestone=${options.milestone}`;
      divider = '&';
    }

    // request issues only for specific state, if state is set
    if (typeof _options.state === 'string' && ['opened', 'closed'].indexOf(_options.state) >= 0) {
      requestUrl += '&state=' + _options.state;
    if (typeof options.state === 'string') {
      requestUrl += `${divider}state=${options.state}`;
      // divider = '&';
    }

    return this.makeGitLabAPIRequest(requestUrl);