Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
  • R rfc4880bis
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 40
    • Issues 40
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 18
    • Merge requests 18
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar

GitLab 15.0 is launching on May 22! This version brings many exciting improvements, but also removes deprecated features and introduces breaking changes that may impact your workflow. To see what is being deprecated and removed, please visit Breaking changes in 15.0 and Deprecations.

  • openpgp-wg
  • rfc4880bis
  • Merge requests
  • !89
Closed
Created Oct 19, 2021 by Daniel Kahn Gillmor@dkgOwner
  • Review changes

  • Download
  • Email patches
  • Plain diff

Drop extra/redundant octet counts for v5 public keys.

  • Overview 3
  • Commits 1
  • Changes 1

The v5 key format contains a series of octet fields that are redundant with other parsing information contained in the packet.

These fields increase the size of the packet on the wire, and they create a new risks of incompatibilities: what if these fields don't match what the rest of the packet lengths suggest? how does an implementation deal with that kind of overflow?

However, they provide a useful feature, which is that they permit calculation of the fingerprint based on a secret key packet even for an unknown public key algorithm.

This change proposes removing these fields from the wire (making v5 public keys functionally equivalent to v4 public keys, but with a different fingerprint calculation method), while adding one trailing field to the v5 secret key packet to facilitate secret key to public key transformations (and therefore fingerprint calculation).

Closes: #43 (closed)

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: simplify-v5-keys