e31x_mimo_xcvr_ad5662.hdl does not build correctly.
Summary
When I ran ocpiadmin install platform e31x I found an error in building this particular component. As can be seen from the relevant logs and/or screenshots section there is a couple errors when trying to build this particular folder. Same can be seen when individually building and not just running the master command.
Steps to reproduce
Trying to build the folder on the same OpenCPI version. Notably no issues when ran on OpenCPI on v2.4.2 which is interesting.
Context
This issue can be reliably run into using v2.4.4. I was trying to run ocpiadmin install platform e31x from the top-level.
Expected correct behaviuor
If I run ocpiadmin install platform e31x it would be expected this particular folder should build fine and not run into issues. Same for building it generally.
Relevant logs and/or screenshots
Environment info
- OpenCPI Version used: 2a67d58d
- Operating System and version (ex. CentOS 7): CentOS 7
Possible fixes
<!-- TODO/FIXME - This is an implementation that REQUIRES the only item on the
SPI bus being the AD5662; that aspect needs to be refactored for generic
non-E3XX usage." -->
<HdlDevice language='vhdl' spec='e31x_mimo_xcvr_ad5662-spec' RawProperties='True' libraries='platform'>
<ControlInterface Timeout='512'>
<Property name='voltageScale' type='ulong' writable='1' default='0x7FFF'/>
</ControlInterface>
<property name="botch" type="uchar" volatile="true"/>
<Signal output='TUNE_DAC_SYNCn' /> <!-- Pin 20 -->
<Signal output='TUNE_DAC_SCLK' /> <!-- Pin 22 -->
<Signal output='TUNE_DAC_SDIN' /> <!-- Pin 24 -->
<Signal input='VCTCXO_TO_MB' /> <!-- Pin 30 -->
</HdlDevice>
Have added a "botch" property which makes sure there is a props_from_worker declared. But, as the property name suggests this is a botch fix for the moment and may have issues further down the line.
Acceptance criteria
Build fine on the current commit date or fix for the forthcoming patches. I wonder if something new added has caused this since as stated works fine on v2.4.2?