openbravo merge requestshttps://gitlab.com/openbravo/product/openbravo/-/merge_requests2024-03-27T18:04:48Zhttps://gitlab.com/openbravo/product/openbravo/-/merge_requests/1179Draft: RM-12639: Infrastructure to have 2 different scanning handlers for CRM...2024-03-27T18:04:48ZJustin PattersonDraft: RM-12639: Infrastructure to have 2 different scanning handlers for CRM connectorWIP commit 1WIP commit 1Justin PattersonJustin Pattersonhttps://gitlab.com/openbravo/product/openbravo/-/merge_requests/1178Fixes ISSUE-0055012: Problem in loading the data in Business API Data Load wi...2024-03-22T12:44:16Zmeriem azafFixes ISSUE-0055012: Problem in loading the data in Business API Data Load window## Description
Problem in loading data through the Business API Data Load window. An InvalidCSRFToken error message is showed in the log.
The problem is that now we are checking that the csrfToken parameter of POST requests, but we mis...## Description
Problem in loading data through the Business API Data Load window. An InvalidCSRFToken error message is showed in the log.
The problem is that now we are checking that the csrfToken parameter of POST requests, but we missed to include the CSRF token in one of them. So we include it.
## Test
- [Try](https://builds.openbravo.com/job/try-init/3516/console)meriem azafmeriem azafhttps://gitlab.com/openbravo/product/openbravo/-/merge_requests/1177RM-12210: Exposing UserSessionSetter to implement Role change in application ...2024-03-27T16:49:49ZJavier Armendárizj.armendariz@orisha.comRM-12210: Exposing UserSessionSetter to implement Role change in application mode switch requestJavier Armendárizj.armendariz@orisha.comJavier Armendárizj.armendariz@orisha.comhttps://gitlab.com/openbravo/product/openbravo/-/merge_requests/1172Fixes ISSUE-54614: Enabled Child Property in Parent Entity to true2024-03-21T11:01:18ZRam PrakashFixes ISSUE-54614: Enabled Child Property in Parent Entity to trueChanged Child Property in Parent Entity to true for M_Product_ID in ServiceProductCategory table
TRY BO RESULT- https://builds.openbravo.com/job/try-init/3475/console
- https://builds.openbravo.com/job/try-init/3483/consoleChanged Child Property in Parent Entity to true for M_Product_ID in ServiceProductCategory table
TRY BO RESULT- https://builds.openbravo.com/job/try-init/3475/console
- https://builds.openbravo.com/job/try-init/3483/consoleRam PrakashRam Prakashhttps://gitlab.com/openbravo/product/openbravo/-/merge_requests/1170Adds some security headers:2024-03-12T22:49:12ZAugusto Mauchaugusto.mauch@openbravo.comAdds some security headers:httpResp.setHeader("X-Frame-Options", "SAMEORIGIN");
httpResp.setHeader("X-Permitted-Cross-Domain-Policies", "none");
httpResp.setHeader("Referrer-Policy", "same-origin");
httpResp.setHeader("X-Frame-Options", "SAMEORIGIN");
...httpResp.setHeader("X-Frame-Options", "SAMEORIGIN");
httpResp.setHeader("X-Permitted-Cross-Domain-Policies", "none");
httpResp.setHeader("Referrer-Policy", "same-origin");
httpResp.setHeader("X-Frame-Options", "SAMEORIGIN");
Closes RM-8122https://gitlab.com/openbravo/product/openbravo/-/merge_requests/1169Draft: Fixed RM-11684: Nested Handling Units support in Core2024-03-27T17:35:41ZVíctor Martínez RomanosDraft: Fixed RM-11684: Nested Handling Units support in CoreVíctor Martínez RomanosVíctor Martínez Romanoshttps://gitlab.com/openbravo/product/openbravo/-/merge_requests/1163Related To ISSUE-RM-11902: Storage Type for Goods Transaction Data Model2024-03-26T17:54:44ZAtul GawareRelated To ISSUE-RM-11902: Storage Type for Goods Transaction Data Model### Screenshots for UXTeam
Storage Bin: Form View
![StorageBinFormView](/uploads/d83341bc33ddb681bb7994624d4f679a/StorageBinFormView.png)
Storage Bin: Grid View
![StorageBinGridView](/uploads/b30cdd5cda778dcdde3a8f421cf41d42/StorageBin...### Screenshots for UXTeam
Storage Bin: Form View
![StorageBinFormView](/uploads/d83341bc33ddb681bb7994624d4f679a/StorageBinFormView.png)
Storage Bin: Grid View
![StorageBinGridView](/uploads/b30cdd5cda778dcdde3a8f421cf41d42/StorageBinGridView.png)
Storage Bin - Help
![StorageBinHelp0](/uploads/cc514716facc429ad9a9e5addb5bb041/StorageBinHelp0.png)
Storage Bin - Help
![StorageBinHelp1](/uploads/b5e7a8ca0a9a82e46fd43153bfaeab1c/StorageBinHelp1.png)
Handling Unit Type Tab: Form View
![04_LocatorHandlingUnitType_FormView](/uploads/359aace0b852cece87965eb200e96fac/04_LocatorHandlingUnitType_FormView.png)
Handling Unit Type Tab: Grid View
![05_LocatorHandlingUnitTypeGridView](/uploads/990f55c550f49fa852850e33dedba246/05_LocatorHandlingUnitTypeGridView.png)
Handling Unit Type Help
![08_Locator_HUType_Help_1](/uploads/edb555a1f4767800b9e7d9877070394f/08_Locator_HUType_Help_1.png)
Handling Unit Type Help
![09_Locator_HUType_Help_2](/uploads/a927c56c8381390c0d50bbe6fb14cc9b/09_Locator_HUType_Help_2.png)
### Jira
https://openbravo.atlassian.net/browse/RM-11902
### try with all jobs Success
https://builds.openbravo.com/job/try-init/3502
### try-retail Success
https://builds.openbravo.com/job/try-ret-init/11176/
### try POS2 Success
https://builds.openbravo.com/job/try-pos2-init/5862
### mod-merged Success
https://builds.openbravo.com/job/mod-merged/1809/
### User Guide
https://docs.google.com/document/d/1C-VjgRRo5DTlKC2T-pLzuHVEBEwYSZrIMgW6XfqdYO8/edit
### Proof of testing
https://docs.google.com/spreadsheets/d/1jz5GHzROaYIVMQVA7VLczseyCzyCAd9NlWSZ44lUGk8/edit#gid=0
### Related MR's
https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.sampledata/-/merge_requests/90
https://gitlab.com/openbravo/ci/modules/org.openbravo.retail.testsampledata/-/merge_requests/89
https://gitlab.com/openbravo/ci/modules/org.openbravo.test.mobile.sampledata/-/merge_requests/127
https://gitlab.com/openbravo/ci/modules/org.openbravo.warehouse.advancedwarehouseoperations.sampledata/-/merge_requests/27Atul GawareAtul Gawarehttps://gitlab.com/openbravo/product/openbravo/-/merge_requests/1161Draft: related to RM-11377: Changes to support Web Authentication (phase 2)2024-03-27T10:19:04ZCarlos AristuDraft: related to RM-11377: Changes to support Web Authentication (phase 2)## Description
- Make `isExternalLoginRequest` method visible for the subclasses
- Add new AD messages
- Add new method to clear the value linked to a configuration
- Add constant for `F&BAdmin` user
- Change some mock methods implemen...## Description
- Make `isExternalLoginRequest` method visible for the subclasses
- Add new AD messages
- Add new method to clear the value linked to a configuration
- Add constant for `F&BAdmin` user
- Change some mock methods implementation to make WebAuthn tests work
## To Be Merged With
* https://gitlab.com/openbravo/product/pmods/org.openbravo.authentication.webauthn/-/merge_requests/2Carlos AristuCarlos Aristuhttps://gitlab.com/openbravo/product/openbravo/-/merge_requests/1153Draft: fixes BUG-54768: error reading functions if oid excedes max int value2024-02-27T11:02:34ZAsier LostaléDraft: fixes BUG-54768: error reading functions if oid excedes max int valueWhen oid excedes the maximum value for int in Java, an error is thrown reading
functions from pg catalog.
Changed to read them as long instead of integer.When oid excedes the maximum value for int in Java, an error is thrown reading
functions from pg catalog.
Changed to read them as long instead of integer.Asier LostaléAsier Lostaléhttps://gitlab.com/openbravo/product/openbravo/-/merge_requests/114554689: Cleanup set of widget available in backoffice workspace (broken,obsole...2024-03-07T12:31:23ZStefan Huehner54689: Cleanup set of widget available in backoffice workspace (broken,obsolete ones)This cleanups several widgets available in backoffice which are:
- either broken
- or outdated/obsolete
Note: One junit test is modified to not use removed widgets (but others instead)
try: https://builds.openbravo.com/view/try/job/try...This cleanups several widgets available in backoffice which are:
- either broken
- or outdated/obsolete
Note: One junit test is modified to not use removed widgets (but others instead)
try: https://builds.openbravo.com/view/try/job/try-init/3330/
- okay, except api handled here: openbravo/ci/backoffice-api/-/merge_requests/65
try-retail: https://builds.openbravo.com/job/try-ret-init/10838/
- okay, except 2-3 unrelated false positives
- Especially both back + extra sampledata install.source working (with changes in their MR's in here)Stefan HuehnerStefan Huehnerhttps://gitlab.com/openbravo/product/openbravo/-/merge_requests/1143Draft: Fixes ISSUE-54685: Remove unnecessary obkmo_widget_class_access rows.2024-02-15T12:41:34ZStefan HuehnerDraft: Fixes ISSUE-54685: Remove unnecessary obkmo_widget_class_access rows.Widget classes marked with allow_anonymous_access = 'Y' are made
available for all roles.
So we do not need to keep obkmo_widget_class_access entries for those
cases.
This is follow-up and very similar to cleanup done in 53408 (for
autom...Widget classes marked with allow_anonymous_access = 'Y' are made
available for all roles.
So we do not need to keep obkmo_widget_class_access entries for those
cases.
This is follow-up and very similar to cleanup done in 53408 (for
automatic ad_role entries).
Creation of such _access rows was already moved from the
obkmo_widget_class_trg in issue 53408.Stefan HuehnerStefan Huehnerhttps://gitlab.com/openbravo/product/openbravo/-/merge_requests/1135Draft: RM-4145: Contributions2024-03-26T13:56:16ZFrank GonzálezDraft: RM-4145: Contributions# Overview
This development adds a new product type called Contribution as well as extending the Product model configuration through the addition of a Product Subtype. A Contribution can be defined as an extra charge associated with a p...# Overview
This development adds a new product type called Contribution as well as extending the Product model configuration through the addition of a Product Subtype. A Contribution can be defined as an extra charge associated with a product, e.g. an "Eco-tax" on a product that contains plastic. Contributions are primarily configured via their product subtype.
## What's New
### Application Dictionary
#### _New & Modified Tables and Columns_
**Product Subtype**
A record in Tables and Columns has been created for the Product Subtype model with the following configuration:
| Table Name | DB Table | Data Package | Java Class | **Data Access Level** |
|------------|----------|--------------|------------|-----------------------|
| ProductSubtype | M_Product_Subtype | org.openbravo.model.common.plm | ProductSubtype | Client/Organization |
| Column Name | DB Column | Reference |
|-------------|-----------|-----------|
| Client | AD_Client_ID | TableDir |
| Linkable To Products | Linkabletoproducts | YesNo |
| Organization | AD_Org_ID | TableDir |
| Product Subtype | M_Product_Subtype_ID | ID |
| Price Calculation | Pricecalculation | List |
| Created By | Createdby | Search |
| Name | Name | String |
| Included In Product Price | Includedinproductprice | YesNo |
| Description | Description | String |
| Creation Date | Created | DateTime |
| Search Key | Value | String |
| Updated By | Updatedby | Search |
| Quantity Rule | Quantity_Rule | List |
| Updated | Updated | DateTime |
| Active | Isactive | YesNo |
| Allocation Type | Allocationtype | List |
| Forced In Returns | Forcedinreturns | YesNo |
**Product**
A new column referencing the Product Subtype table has been added to the Product table with the following values:
| Column Name | DB Column | Reference |
|-------------|-----------|-----------|
| Product Subtype | M_Product_Subtype_ID | TableDir |
#### _New & Modified Windows, Tabs, and Fields_
**Product Subtype**
A window has been created for the Product Subtype table with the following elements:
| Window Name | Window Type |
|-------------|-------------|
| Product Subtype | Maintain |
| Tab Name | Table | UI Pattern | Tab Level |
|----------|-------|------------|-----------|
| Product Subtype | M_Product_Subtype | Standard | 0 |
| Field Name | DB Column | Sequence Number | Displayed |
|------------|-----------|-----------------|-----------|
| Client | AD_Client_ID | | No |
| Product Subtype | M_Product_Subtype_ID | | No |
| Organization | AD_Org_ID | 10 | Yes |
| Search Key | Value | 20 | Yes |
| Name | Name | 30 | Yes |
| Description | Description | 40 | Yes |
| Linkable To Products | Linkabletoproducts | 50 | Yes |
| Included In Product Price | Includedinproductprice | 60 | Yes |
| Allocation Type | Allocationtype | 70 | Yes |
| Forced In Returns | Forcedinreturns | 80 | Yes |
| Quantity Rule | Quantity_Rule | 90 | Yes |
| Active | Isactive | 100 | Yes |
| Price Calculation | Pricecalculation | 110 | Yes |
**Product**
The Product window has been modified with the addition of the following field for Product Subtype:
| Field Name | DB Column | Sequence Number | Displayed |
|------------|-----------|-----------------|-----------|
| Product Subtype | M_Product_Subtype_ID | 115 | Yes |
The following elements' names have been changed:
| Element Type | Previous Name | New Name |
|--------------|---------------|----------|
| Tab | Products | Related Products |
| Tab | Product Categories | Relate Product Categories |
| Field Group | Service Product | Relatable Product |
In addition to the naming changes, several fields had some properties changed:
<table>
<tr>
<th>Field Name</th>
<th>Changes To</th>
</tr>
<tr>
<td>Quantity Rule</td>
<td>
* description
</td>
</tr>
<tr>
<td>Product Type</td>
<td>
* description
</td>
</tr>
<tr>
<td>Linked To Product</td>
<td>
* description
</td>
</tr>
<tr>
<td>Relate Products</td>
<td>
* description
* help
* display logic
</td>
</tr>
<tr>
<td>Relate Prod Categories</td>
<td>
* description
* help
* display logic
</td>
</tr>
<tr>
<td>Included Products</td>
<td>
* display logic
</td>
</tr>
<tr>
<td>Included Product Categories</td>
<td>
* display logic
</td>
</tr>
</table>
#### _New Menu Item_
A new menu entry has been created for the Product Subtype window.
#### _New Message_
The following message has been created:
| Message Name | Text |
|--------------|------|
| M_PRODUCT_CONTRIBUTION_CHECK | If the product is a contribution, a product subtype must be selected. |
#### _New & Modified References_
Two new list references have been created with the following values:
<table>
<tr>
<th>List Name</th>
<th>Values</th>
</tr>
<tr>
<td>Product Subtype Price Calculation</td>
<td>
* L - "As listed in price list"
* W - "By product weight"
</td>
</tr>
<tr>
<td>Product Subtype Allocation Type</td>
<td>
* M - "Mandatory"
</td>
</tr>
</table>
The following references have been modified:
| List Name | Change |
|-----------|--------|
| Quantity Rule | Description modified |
| M_Product_ProductType | Added new list value: C - "Contribution" |
### Data Model
**M_PRODUCT_SUBTYPE**
A model definition has been created for the Product Subtype model with the following columns:
| Column Name | Required | Type | Size | Default |
|-------------|----------|------|------|---------|
| M_PRODUCT_SUBTYPE_ID (PK) | Y | VARCHAR | 32 | |
| AD_CLIENT_ID (FK) | Y | VARCHAR | 32 | |
| AD_ORG_ID (FK) | Y | VARCHAR | 32 | |
| ISACTIVE | Y | CHAR | 1 | Y |
| CREATED | Y | TIMESTAMP | 7 | SYSDATE |
| CREATEDBY | Y | VARCHAR | 32 | |
| UPDATED | Y | TIMESTAMP | 7 | SYSDATE |
| UPDATEDBY | Y | VARCHAR | 32 | |
| VALUE | Y | VARCHAR | 40 | |
| NAME | Y | VARCHAR | 60 | |
| DESCRIPTION | N | VARCHAR | 255 | |
| LINKABLETOPRODUCTS | Y | CHAR | 1 | Y |
| PRICECALCULATION | Y | VARCHAR | 60 | L |
| INCLUDEDINPRODUCTPRICE | Y | CHAR | 1 | N |
| ALLOCATIONTYPE | Y | VARCHAR | 60 | M |
| FORCEDINRETURNS | Y | CHAR | 1 | Y |
| QUANTITY_RULE | Y | VARCHAR | 60 | PP |
The model includes the following foreign key constraints:
| FK Constraint Name | Foreign Table | References | Local Key |
|--------------------|---------------|------------|-----------|
| M_PRODUCT_SUBTYPE_AD_CLIENT | AD_CLIENT | AD_CLIENT_ID | AD_CLIENT_ID |
| M_PRODUCT_SUBTYPE_AD_ORG | AD_ORG | AD_ORG_ID | AD_ORG_ID |
The model includes a unique constraint defined as:
<table>
<tr>
<th>Unique Constraint Name</th>
<th>Columns</th>
</tr>
<tr>
<td>M_PRODUCT_SUBTYPE_VALUE</td>
<td>
* VALUE
* AD_ORG_ID
* AD_CLIENT_ID
</td>
</tr>
</table>
The model includes the following checks:
| Check Name | Condition |
|------------|-----------|
| M_PROD_SUBTYPE_FRCDINRTRNS_CHK | FORCEDINRETURNS IN ('Y', 'N') |
| M_PROD_SUBTYPE_INPRODPRICE_CHK | INCLUDEDINPRODUCTPRICE IN ('Y', 'N') |
| M_PROD_SUBTYPE_LINKTOPRODS_CHK | LINKABLETOPRODUCTS IN ('Y', 'N') |
| M_PRODUCT_SUBTYPE_ISACTIVE_CHK | ISACTIVE IN ('Y', 'N') |
**M_PRODUCT**
The Product model definition has been changed with the addition of the following elements:
| Column Name | Required | Type | Size | Default |
|-------------|----------|------|------|---------|
| M_PRODUCT_SUBTYPE_ID (PK) | Y | VARCHAR | 32 | |
| FK Constraint Name | Foreign Table | References | Local Key |
|--------------------|---------------|------------|-----------|
| M_PRODUCT_M_PRODUCT_SUBTYPE | M_PRODUCT_SUBTYPE | M_PRODUCT_SUBTYPE_ID | M_PRODUCT_SUBTYPE_ID |
| Check Name | Condition |
|------------|-----------|
| M_PRODUCT_CONTRIBUTION_CHECK | PRODUCTTYPE \<\> 'C' OR M_PRODUCT_SUBTYPE_ID IS NOT NULL |
## Links
### Jira: [RM-4145](https://openbravo.atlassian.net/browse/RM-4145)
### Mantis: [54623](https://issues.openbravo.com/view.php?id=54623)
### MRs:
* Backoffice API: https://gitlab.com/openbravo/ci/backoffice-api/-/merge_requests/67
* WebPOS: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1466
* Business API: https://gitlab.com/openbravo/product/pmods/org.openbravo.api/-/merge_requests/238
* WebPOS2: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/2478
### Docs:
* [Functional Spec](https://docs.google.com/document/d/1XQ0DnW_rqeyMzbka_3sI7lTciCp-zVbRUTt8QqP4xeI/edit)
* [Technical Spec](https://docs.google.com/document/d/1YOxvbjO49onp-cjNgnGpL9ueF0Au3VCBqXTjo0NZ4vA/edit)
* [Estimations](https://docs.google.com/spreadsheets/d/1FY0tGypequkb9XB8AMopPHN0tCfBcz8vw79ylXf1YF4)
* [Proof of Testing](https://docs.google.com/spreadsheets/d/1AVTySbIUpGk8BO9Q0AgiZiSIuWldAmeSFbl0Uzpd3fE)
# Testing Performed
* [try-backoffice](https://builds.openbravo.com/job/try-init/3517/console) (error due to API change -\> openbravo/ci/backoffice-api!67)
* try-retail
* [try-pos2](https://builds.openbravo.com/job/try-pos2-init/5982/console)
# UX Approval
### Backoffice Screenshots
<table>
<tr>
<th colspan="2" align="center">
#### **Product Subtype window**
</th>
</tr>
<tr>
<td align="center">
Form view
![Product_Subtype\<span data-escaped-char\>\<span data-escaped-char\>\<span data-escaped-char\>\<span data-escaped-char\>\<span data-escaped-char\>\<span data-escaped-char\>\<span data-escaped-char\>\<span data-escaped-char\>\_\</span\>\</span\>\</span\>\</span\>\</span\>\</span\>\</span\>\</span\>(Form).png](/uploads/37a59ceac8b5f3de2b5041c86c5d3ee4/Product_Subtype__Form_.png)
</td>
<td align="center">
Grid view
![Product_Subtype\<span data-escaped-char\>\<span data-escaped-char\>\<span data-escaped-char\>\<span data-escaped-char\>\<span data-escaped-char\>\<span data-escaped-char\>\<span data-escaped-char\>\<span data-escaped-char\>\_\</span\>\</span\>\</span\>\</span\>\</span\>\</span\>\</span\>\</span\>(Grid).png](/uploads/c5b73fb67024a84fe2ab4076b6188f3a/Product_Subtype__Grid_.png)
</td>
</tr>
<tr>
<td colspan="2" align="center">
Help
![Product_Subtype_Help.png](/uploads/328e4be7d7609b5c9716bf029ddfb81e/Product_Subtype_Help.png)
</td>
</tr>
</table>
<table>
<tr>
<th align="center">
#### **Product window**
</th>
</tr>
<tr>
<td align="center">
Form view
![Product\<span data-escaped-char\>\<span data-escaped-char\>\<span data-escaped-char\>\<span data-escaped-char\>\<span data-escaped-char\>\<span data-escaped-char\>\<span data-escaped-char\>\<span data-escaped-char\>\_\</span\>\</span\>\</span\>\</span\>\</span\>\</span\>\</span\>\</span\>(Form).png](/uploads/257fab3f6ea775aee18022263ad70d9e/Product__Form_.png)
</td>
</tr>
<tr>
<td align="center">
Error message
![M_PRODUCT_CONTRIBUTION_CHECK.png](/uploads/a2c982c791e75798950975ec9974afc1/M_PRODUCT_CONTRIBUTION_CHECK.png)
</td>
</tr>
</table>Frank GonzálezFrank Gonzálezhttps://gitlab.com/openbravo/product/openbravo/-/merge_requests/1127CRA(create-react-app) should be replaced by an alternative, Vite2024-03-25T13:54:32ZCristian Bernerc.berner@orisha.comCRA(create-react-app) should be replaced by an alternative, Vite## Main MR
- [ ] https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/1357## Main MR
- [ ] https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/1357Cristian Bernerc.berner@orisha.comCristian Bernerc.berner@orisha.comhttps://gitlab.com/openbravo/product/openbravo/-/merge_requests/1087Fixes ISSUE-54223 Fix Warning in Mockito Tests related with Enable Dynamic...2023-12-27T12:44:30ZAdrián BlascoFixes ISSUE-54223 Fix Warning in Mockito Tests related with Enable Dynamic...Fixes ISSUE-54223 Fix Warning in Mockito Tests related with Enable Dynamic Agent Loading in compiler.
## JEP 451
In Java 21, a new JDK Enhancement Proposal adds a Warning message during compilation.
https://openjdk.org/jeps/451
This me...Fixes ISSUE-54223 Fix Warning in Mockito Tests related with Enable Dynamic Agent Loading in compiler.
## JEP 451
In Java 21, a new JDK Enhancement Proposal adds a Warning message during compilation.
https://openjdk.org/jeps/451
This message should not appear anymore when **mockito tests** are running.
![Screenshot_from_2023-12-21_12-57-09](/uploads/5ed3663236b6447fe64307ffe5440731/Screenshot_from_2023-12-21_12-57-09.png)
## Mockito Tests
ant run.test -Dtest=org.openbravo.synchronization.event.SynchronizationEventTest
ant run.test -Dtest=org.openbravo.api.event.ApiSubscriptionResolverTest
ant run.test -Dtest=org.openbravo.api.event.ApiEventEDLRequestCreatorTest
ant run.test -Dtest=org.openbravo.mobile.core.report.ReprintableDocumentServiceTestAdrián BlascoAdrián Blascohttps://gitlab.com/openbravo/product/openbravo/-/merge_requests/1055Draft: ISSUE-52828: Tomcat 10 migration2023-11-27T22:52:49ZGonzalo Fernández Garcíagonzalo.fernandez@openbravo.comDraft: ISSUE-52828: Tomcat 10 migrationThis MR will remain in draft mode, unmerged, until the RM team can confirm that the proposed approach of exporting to webapps-javaee is valid.
## Description:
This merge requests contains the required changes in order to enable us to ...This MR will remain in draft mode, unmerged, until the RM team can confirm that the proposed approach of exporting to webapps-javaee is valid.
## Description:
This merge requests contains the required changes in order to enable us to work with both Tomcat 8.5 and 10.1. This is possible thanks to a new boolean property in Openbravo.properties called deploy.tomcat10, that when set to true, changes the target directory where the code is deployed and allows Tomcat 10 to automatically migrate it. For further information have a look at the documentation below.
## Linked MRs:
- [core2](https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/1292)
## Links:
- [Functional Documentation](https://docs.google.com/document/d/1mQ-bEZ97i8KBlSjwMZXuY_BY_LWa8JLZhrxtvmkb0k4)
- [Technical Documentation](https://docs.google.com/document/d/1jaKFr2hqS9FwZjO0wYQ1G5h5xFIrLi-KB7LHUBqTJjY)
- [Proof of Testing](https://docs.google.com/spreadsheets/d/1SgJ5WFckCsOATewU9J-ngoXSv0CIhav5_wZ9GA24wVg)Gonzalo Fernández Garcíagonzalo.fernandez@openbravo.comGonzalo Fernández Garcíagonzalo.fernandez@openbravo.comhttps://gitlab.com/openbravo/product/openbravo/-/merge_requests/1015Fixes ISSUE-52769: Changed column reference from Number to Price for Column G...2023-10-11T12:30:17ZRam PrakashFixes ISSUE-52769: Changed column reference from Number to Price for Column GrossPriceList and DiscountDescription:
* Changed column reference from Number to Price for Column GrossPriceList and Discount
* Columns GrossPriceList and Discount updated with reference "Price" from "Number"
TRY-backoffice:
https://builds.openbravo.com/job/tr...Description:
* Changed column reference from Number to Price for Column GrossPriceList and Discount
* Columns GrossPriceList and Discount updated with reference "Price" from "Number"
TRY-backoffice:
https://builds.openbravo.com/job/try-init/2756/consoleRam PrakashRam Prakashhttps://gitlab.com/openbravo/product/openbravo/-/merge_requests/1003Draft: Use Dependency management with Apache Ivy instead of physical jar-files2023-09-22T16:07:35ZVladimir V. BychkovDraft: Use Dependency management with Apache Ivy instead of physical jar-filesNow project uses hardcoded jar-files of dependencies instead of any dependency management tool. This is bad for several reasons, f.e. :
1. Absent or erroneous transitive dependencies artifacts (oh, human forgetfulness)
2. Huge git-reposi...Now project uses hardcoded jar-files of dependencies instead of any dependency management tool. This is bad for several reasons, f.e. :
1. Absent or erroneous transitive dependencies artifacts (oh, human forgetfulness)
2. Huge git-repository size
With this PR I propose the usage of [Apache Ivy](https://ant.apache.org/ivy/) - Ant-oriented dependency management tool. It has a plugin for Eclipse IDE - IvyDE, which is accessible in Eclipse Marketplace and full functional for last versions of Eclipse too.
Applying of this PR makes unnecessary [this wiki-page](http://wiki.openbravo.com/wiki/Openbravo_Libraries).https://gitlab.com/openbravo/product/openbravo/-/merge_requests/982Fixes ISSUE-50169: Handled negative values in Discount Amount field2023-10-04T06:12:12Zsabarinath palanisamyFixes ISSUE-50169: Handled negative values in Discount Amount fieldDescription: When the user enters negative value in Discount Amount field it raises an error "Invalid Entry!"
Retail build: https://builds.openbravo.com/job/try-init/2484/consoleDescription: When the user enters negative value in Discount Amount field it raises an error "Invalid Entry!"
Retail build: https://builds.openbravo.com/job/try-init/2484/consolesabarinath palanisamysabarinath palanisamyhttps://gitlab.com/openbravo/product/openbravo/-/merge_requests/950Review and remove modulescripts only required for updates from <16Q1 - omni -...2024-03-19T11:54:34ZStefan HuehnerReview and remove modulescripts only required for updates from <16Q1 - omni - part2Review and remove modulescripts only required for updates from \<16Q1 - omni - part2
Any modulescript running on upgrades from \<16Q1 is no longer needed and can be removed if it is marked as NOT running also during install.source
Many...Review and remove modulescripts only required for updates from \<16Q1 - omni - part2
Any modulescript running on upgrades from \<16Q1 is no longer needed and can be removed if it is marked as NOT running also during install.source
Many (very) old modulescripts when created before being able to declare executeOnInstall=false. Those old ones need be reviewed one-by-one if they can be safely skipped during install and then be removed as obsolete
https://issues.openbravo.com/view.php?id=53029
try:
- https://builds.openbravo.com/job/try-init/3432/
List of active sampledata being reviewed:
- backoffice (both F&B and QA Testing)
- org.openbravo.pos2.sampledata
- org.openbravo.pos2.restaurant.sampledata
- org.openbravo.pos2.marketingsurvey.sampledata
- org.openbravo.warehouse.advancedwarehouseoperations.sampledata
- org.openbravo.service.integration.sap.ecc.mappings
- org.openbravo.retail.giftcards.pos2-sampledata
- org.openbravo.retail.sampledata.hgvolStefan HuehnerStefan Huehnerhttps://gitlab.com/openbravo/product/openbravo/-/merge_requests/946Draft: ISSUE-52985: [hideMenu-isNewUI] Assume isNewUI==true2023-07-17T15:54:46ZStefan HuehnerDraft: ISSUE-52985: [hideMenu-isNewUI] Assume isNewUI==trueIssue https://issues.openbravo.com/view.php?id=13891 started hiding some bits of full 2.50 old UI when running in new UI.
With 3.0 / newUI being the only & default now it is no longer useful to run the full old 2.50 UI (see issue for a ...Issue https://issues.openbravo.com/view.php?id=13891 started hiding some bits of full 2.50 old UI when running in new UI.
With 3.0 / newUI being the only & default now it is no longer useful to run the full old 2.50 UI (see issue for a screenshot
Assume that is never wanted/useful and cleanup the code accordingly.
TODO:
* Reference https://issues.openbravo.com/view.php?id=52985
* either squash commits on merge
* or add merge commit for it
* try: https://builds.openbravo.com/view/try/job/try-init/2400/Stefan HuehnerStefan Huehner