Skip to content

GitLab

    • GitLab: the DevOps platform
    • Explore GitLab
    • Install GitLab
    • How GitLab compares
    • Get started
    • GitLab docs
    • GitLab Learn
  • Pricing
  • Talk to an expert
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
    • Menu
    Projects Groups Snippets
  • Sign up now
  • Login
  • Sign in / Register
  • D dbsm
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Custom issue tracker
    • Custom issue tracker
  • Merge requests 2
    • Merge requests 2
  • Deployments
    • Deployments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • Code review
    • Insights
    • Issue
    • Repository
  • Activity
  • Graph
  • Commits
Collapse sidebar

GitLab 15.0 is launching on May 22! This version brings many exciting improvements, but also removes deprecated features and introduces breaking changes that may impact your workflow. To see what is being deprecated and removed, please visit Breaking changes in 15.0 and Deprecations.

  • openbravo
  • product
  • dbsm
  • Merge requests
  • !21

ISSUE-47036: Remove support code for update.database.mod, ezattributes module and references to dbmanager.jar

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged
Stefan Huehner requested to merge huehner/dbsm:fr/remove-ezAttributes-updateDatabaseMod into master Feb 03, 2021
  • Overview 0
  • Commits 8
  • Changes 13

update.database.mod is dead long time ago ezattributes module is unsupported also quite a while

Remove lots of code from dbsourcemanager to simplify it a lot.

Especially it removes the 3 slightly different ModelLoader sql variants per topic

This need MR !305 merged before which was still using API removed in here.

TODO

  • (openbravo!305 (merged))
  • rebased
  • dbsm testsuite
  • check all modules for using internal dbsm code
    • unsupported => no need to check
      • org.openbravo.retail.storeserver.synchronization, org.openbravo.replication.symmetricds, org.openbravo.ezattributes
    • NI
      • org.openbravo.reporting.tools
        • Check that it still compiles (it extends 4 dbsm classes)
        • No runtime check as no only code-removal in here
      • br.com.disoft.brazil.ce.core
        • Apparently forked via copy'n'paste the in-core SystemValidationTask into src/br/com/disoft/brazil/ce/core/validator/DisoftValidationTask.java
        • Forge published module
  • check all dbsm usage in openbravo sourcecode
    • Relevant DatabaseValidator, SystemService only usage left is via dbsm ExportDatabase itself
    • junit test ClientExportImportTest
    • Note that 2 more usages were removed in 21Q2 already (https://issues.openbravo.com/view.php?id=29855) and (https://issues.openbravo.com/view.php?id=29853)
  • OB-owned module marked still as supported but depends on already broken ezattributes
    • Library-To-Window
      • Module updated to Unsupported after checking with aza (was custom for a client, no longer useful/needed)
  • try run
    • try-initial => both false positive (run was accidentally with release/21Q1 missing logo commit)
  • try-retail run?
  • mod-merged run?
  • check/update/report dbmanager removal
Edited Feb 21, 2022 by Santiago Gremiger
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: fr/remove-ezAttributes-updateDatabaseMod