Olivier Lacoste-Bouchet opened merge request !3: Fixes at Luigi Calligaris / OpenIPMC

Olivier Lacoste-Bouchet
2022-10-12T16:21:40Z

Had a bit of a misunderstanding with my last MR sorry if you saw that ...

Check for FreeRTOS resource returns and at least notify the user

Prevent possible buffer overrun in debug print. Since messages shouldn't exceed 32 bytes it's unlikely this happens but better to be safe than sorry

use of a const variable in a constant expression is nonstandard in C -> warning from my compiler, should instead be a #define macro

hpm1_upgrade_task_handle define twice in header

Hopefully the image attaches. I believe the responder LUN and requestor LUN should be accounted for and swapped when creating the reply message. Currently, the requestor LUN is dropped from byte[4] to gather the sequence number of the request. The sequence number is then placed in byte[4] of the response without a LUN.

The image is from ipmi-intelligent-platform-mgt-interface-spec-2nd-gen-v2-0-spec-update page 163 fig 13-4. Observe the 2 LUN values. {{image.png}}