XLIFFWriter doesn't write all PO comment types

Created by: Anonymous

Original issue 195 created by thry... on 2011-11-15T18:52:24.000Z:

Hi,

I am converting a PO file to XLIFF using the XLIFFWriter. I have noticed that when the PO file contains comments, only extracted comments are being written to the XLIFF file. Additionally, it appears the "from" attribute is left off the XLIFF element.

Looking through the code, POFilter.java defines local properties for the different comment types while XLIFFWriter.java only handles properties defined in Property.java.

Shouldn't the properties defined in POFilter.java be more generic and located in Property.java where XLIFFWriter.java can access them?

My XLIFFWriter is initialized in the following way:

XLIFFWriter writer = new XLIFFWriter();
writer.setCopySource(true);
writer.setIncludeAltTrans(true);

Sincerely,

Shane