Fix mismatched PUSH_SUB/POP_SUB
Description
Using the following oneliner, I extracted all the mismatched PUSH_SUB
/POP_SUB
pairs:
$ git ls-files src/ | xargs -l awk 'match($0, /PUSH_SUB\((.*)\)/, m) { if (!m[1]) { print "Could not match", $0 }; push_sub=m[1] } match($0, /POP_SUB\((.*)\)/, m) { if (m[1] != push_sub) { printf("PUSH/POP mismatch in %s:%d\n Expected: %s\n Got: %s\n", FILENAME, NR, push_sub, m[1]) } }'
PUSH/POP mismatch in src/hamiltonian/lda_u.F90:1273
Expected: X(orbitalset_get_symm_weight)
Got: orbitals_get_symm_weight
PUSH/POP mismatch in src/hamiltonian/nonlocal_pseudopotential_inc.F90:1193
Expected: X(nonlocal_pseudopotential_position_commutator)
Got: X(nonlocal_pseudopotential_nlocal_position_commutator)
PUSH/POP mismatch in src/hamiltonian/xc_vxc_nc_inc.F90:181
Expected: xc_compute_vxc_nc
Got: xc_get_nc_vxc
PUSH/POP mismatch in src/ions/ions.F90:974
Expected: write_bild_forces_file
Got: ions_write_bild_forces_file
PUSH/POP mismatch in src/ions/symmetries.F90:255
Expected: symmetries_constructor
Got: symmetries_init
PUSH/POP mismatch in src/math/lalg_basic_blas_inc.F90:401
Expected: FNAME(axpy_4)
Got: FNAME(axpy_2)
PUSH/POP mismatch in src/math/nfft_inc.F90:80
Expected: znfft_backward
Got: X(nfft_backward)
PUSH/POP mismatch in src/opt_control/opt_control.F90:543
Expected: opt_control_run_legacy.scheme_nlopt
Got: opt_control_run_legacy.scheme_cg
PUSH/POP mismatch in src/opt_control/target_exclude_inc.F90:116
Expected: target_j1_local
Got: target_j1_exclude
PUSH/POP mismatch in src/opt_control/target_hhg_inc.F90:251
Expected: target_init_hhgnew
Got: target_end_hhgnew
PUSH/POP mismatch in src/species/allelectron.F90:554
Expected: species_debug
Got: allelectron_debug
PUSH/POP mismatch in src/states/states_elec_restart.F90:1298
Expected: states_elec_dump_spin
Got: states_dump_spin
PUSH/POP mismatch in src/states/states_elec_restart.F90:1358
Expected: states_elec_load_spin
Got: states_load_spin
PUSH/POP mismatch in src/states/states_elec_restart.F90:1375
Expected: states_elec_load_spin
Got: states_load_spin
PUSH/POP mismatch in src/states/states_mxll_restart.F90:455
Expected: states_mxll_load
Got: states_load
PUSH/POP mismatch in src/sternheimer/phonons_lr_inc.F90:126
Expected: X(phonons_lr_wavefunctions)
Got: phonons_lr_wavefunctions
PUSH/POP mismatch in src/td/td.F90:1163
Expected: td_read_coordinates
Got: td_run.td_read_coordinates
PUSH/POP mismatch in src/td/td.F90:1389
Expected: td_load_frozen
Got: td_load
PUSH/POP mismatch in src/utils/floquet.F90:370
Expected: floquet_solve_non_interacting
Got: solve_non_interacting
The first issue in the list is not fixed in this MR, because it is already part of !2622 (merged)
News snippet
Checklist
-
I have checked that my code follows the Octopus coding standards -
I have added tests for all the new features added in this request.
Edited by Henri Menke