Skip to content

Merge policies are undocumented

We should document when it's OK to merge a change. Here's a start:

  • GitLab CI passes
  • any changes for new functionality add tests for the functionality
    • or the commit message or merge request explains why there are no new tests
  • any fixes for bugs add test that verify the bug is fixed
    • or the commit message or merge request explains why there are no new tests
  • some aspect of the user experience or the code quality is better
  • the user experience or the code quality is not significantly worse in any way
  • if the merge request specified a minimum time for review, to allow wider review, that time has passed

Thoughts? Opinions? Objections? Suggestions?