Minstrel-HT wi-fi rate control implementation bug?

Hello,

I have been reading the Minstrel-HT source code implementation in ns-3 and I came across something that I believe must be a bug.

In the MinstrelHtWifiManager::UpdateRate function:

If the station is currently sampling, sample rate is used only once... and afterwards, Best Rate (or MaxTP) is used. However m_maxTpRate2 is being selected.

The retryCounts also refer to the maxTpGroupId but considering the maxTpRate2Id rate (instead of maxTpRateId).

Later in the code... In the MinstrelHtWifiManager::CountRetries function: If station is currently sampling, it is looking for the station->m_groupsTable[maxTpGroupId].m_ratesTable[maxTp2RateId].retryCount Shouldn't it be maxTpRateId as well?

The comments that are alongside these lines of code also suggest that we should be using MaxTP instead of MaxTP2. However, I'm not fully sure if this is the case, thus the reason for questioning it in the title :)

This is my first issue in this project, so I apologize in advance if I'm not complying with the expected template.

Best Regards,

Rúben Queirós