Skip to content

Follow-up from "Draft: Plonk : Less FFT − Fixes #94"

The following discussions from !120 (merged) should be addressed:

  • @ambrona started a discussion: (+1 comment)

    Is there a way to combine functions op_1 op_2 op_4 into one?

  • @ambrona started a discussion: (+3 comments)

    It would be good to be able to write something like:

    let evaluations = SMap.add evaluations "h1_h2g" (h1 @- comp h2) evaluations

    where @- is an infix for the code below, instead of

        let h1_h2g = "h1_h2g" in
        let evaluations =
          Evaluations.op_2
            ~evaluations
            ~func:Scalar.sub
            ~func_degree:max
            ~composition_p2:(1, size_domain)
            ~names_p1_p2:(h1, h2)
            ~name_result:h1_h2g
            ()
        in

    Shall we give it a try?

  • @MarcBeunardeau started a discussion: (+2 comments)

    The name shift could also be changed to be more explicitely linked with composition

  • @MarcBeunardeau started a discussion: (+1 comment)

    I prefer the use of name_prime rather than name'