version bump from rc which has breaking change, only bumps to non rc version.

📚 Summary

During version bump at commit 5f273ce2 current version was 0.3.0rc1 a breaking change was added within the commit and the version only incremented to 0.3.0 when it should have incremented to 1.0.0.

Git log output for commits in question

$ git log
commit 5f273ce23a331eaf11623207ec4aba8b856c14f0 (HEAD)
Author: Jon Lockwood <{redacted}>
Date:   Sat Aug 7 14:56:51 2021 +0930

    docs(gitlab_release): Updated docs with new instructions on version incrementing
    
    BREAKING CHANGE: !2

commit f76cabeeb04b028a231dc1c232862db5fcad4345
Author: Jon Lockwood <{redacted}>
Date:   Sat Aug 7 13:56:25 2021 +0930

    fix(gitlab_release): Adjust release workflow
    
    Previous release workflow only allowed version increment of RC on development brnach.
    
    adjust to the following workflow:
        master branch: automatically increment the version
        development branch: option to manually increment version (RC increment only)
    
    !2

commit eb5cc8a0e2885a9ed16a8d1a81611aec4d5a4d31 (tag: v0.3.0rc1)
Author: NFC CI <{redacted}>
Date:   Wed Aug 4 03:23:08 2021 +0000

    build(version): bump version 0.3.0rc0 → 0.3.0rc1

command output version bump where breaking change is included:

$ cz -n cz_nfc bump --dry-run
build(version): bump version 0.3.0rc1 → 0.3.0
tag to create: v0.3.0
increment detected: PATCH

❓ Expected Result

Even though the release at the time was a release candidate rc1, due to there being a breaking change, the MAJOR version number should have incremented.

Links / References:

• commitizen Github issue 472

• commitizen version: (test machine 2.17.13) however CI uses current as of date of job. Also tested with cz-0.0.0.0.dev20200924

• BREAKING CHANGE commit 5f273ce23a331eaf11623207ec4aba8b856c14f0

• custom module cz_nfc

👷 Tasks

• ensure that if a breaking change is committed that the major version number increases.

• change tested, works from any minor including rc to a MAJOR release