1. 22 Jan, 2019 1 commit
  2. 11 Jan, 2019 2 commits
  3. 08 Jan, 2019 1 commit
  4. 19 Dec, 2018 1 commit
  5. 17 Dec, 2018 2 commits
    • Lukas 'Eipi' Eipert's avatar
      Add danger check for duplicate yarn dependencies · 243bd56f
      Lukas 'Eipi' Eipert authored
      This danger check utilises `yarn-deduplicate` in order to show duplicate
      dependencies in the yarn.lock dependency tree.
      Often when introducing new dependencies or updating existing ones, yarn
      does not seem to build the most optimal dependency tree.
      
      In order to prevent those unnecessary dependency updates we are nudging
      developers and maintainers to resolve these issues in MRs. Automating
      this with danger especially helps, as yarn.lock files are not that easy
      to review.
      243bd56f
    • Sam Bigelow's avatar
      0f069485
  6. 14 Dec, 2018 1 commit
  7. 06 Dec, 2018 1 commit
  8. 05 Dec, 2018 1 commit
  9. 16 Nov, 2018 1 commit
  10. 12 Nov, 2018 1 commit
  11. 09 Nov, 2018 2 commits
  12. 07 Nov, 2018 1 commit
    • Yorick Peterse's avatar
      Warn when MR titles are too long · edd3e107
      Yorick Peterse authored
      This adds a Danger check to produce a warning for MR titles greater than
      72 characters. This is necessary because when squash on merge is used,
      the MR title will be used for the commit message (at least by default).
      This in turn leads to commit messages that violate our commit message
      guidelines.
      
      For more information, refer to
      gitlab-org/release/framework#24.
      edd3e107
  13. 23 Oct, 2018 1 commit
    • Sean McGivern's avatar
      Also count specs in new files in Danger check · 0e616d71
      Sean McGivern authored
      We have a Danger check that warns if you made changes in app/ but not in
      spec/. However, this only checked for changed files - not new files. If
      you added an app file with no specs, it wouldn't warn; and it would warn
      erroneously if you added a missing spec file while changing a file in
      app/.
      0e616d71
  14. 22 Oct, 2018 1 commit
    • Lukas 'Eipi' Eipert's avatar
      Create helper to get all changed files · 253e1818
      Lukas 'Eipi' Eipert authored
      Danger apparently has three different objects which could contain files
      you often want to check:
      
       - git.added_files
       - git.modified_files
       - git.renamed_files
      
      The problem: If a file is renamed, `modified_files` contains the file
      path before the rename. In some Danger checks we use `added_files` +
      `modified_files`, which might contain the deleted paths of renamed
      files, but missing the new paths of renamed files.
      
      So we need to consider `renamed_files` as well.
      253e1818
  15. 29 Sep, 2018 1 commit
  16. 28 Sep, 2018 1 commit
  17. 19 Sep, 2018 1 commit
  18. 18 Sep, 2018 1 commit
    • Yorick Peterse's avatar
      Improve Emoji detection in commit messages · 4ef1dd09
      Yorick Peterse authored
      This changes our Danger integration so that it is smarter about
      detecting GitLab emoji in commit messages. This is done using a two step
      process:
      
      1. We use the old regular expression to determine if a commit message
         _might_ include an emoji.
      
      2. If this regular expression matches, we then check for all existing
         emoji names in the commit message. This might be a wee bit expensive,
         but because we couple it with the previous step it should be rarely
         executed.
      
      This ensures we don't trigger an error when a commit message includes
      text such as `:foo:bar:`, which is not a valid Emoji.
      
      Fixes gitlab-org/release/framework#15
      4ef1dd09
  19. 14 Sep, 2018 2 commits
    • Lukas 'Eipi' Eipert's avatar
      Fix typo in Danger message · 40f81458
      Lukas 'Eipi' Eipert authored
      40f81458
    • Yorick Peterse's avatar
      Relax Danger requirements about changed lines · 42f90b5f
      Yorick Peterse authored
      This relaxes the commit rules regarding the number of changed lines.
      Previously we required a detailed description if 20 or more lines were
      changed. Starting with this commit we change the rules so Danger only
      notifies you about writing a detailed description if:
      
      1. A commit changes more than 3 files
      2. The same commit changes more than 30 lines
      
      This should make it easier to do a find replace to fix a typo, without
      having to repeat what the subject line already says, while still
      reminding developers to write a detailed description for new features
      and other larger changes.
      
      Fixes gitlab-org/release/framework#13
      42f90b5f
  20. 10 Sep, 2018 1 commit
  21. 06 Sep, 2018 1 commit
  22. 04 Sep, 2018 1 commit
  23. 24 Aug, 2018 1 commit
  24. 25 Jul, 2018 2 commits
  25. 24 Jul, 2018 1 commit
  26. 17 Jul, 2018 2 commits
  27. 13 Jul, 2018 1 commit
  28. 12 Jul, 2018 2 commits
  29. 11 Jul, 2018 5 commits