Make #find_commits_by_message_or_author take in named params

103 jobs for 12760-filter-commits-by-author in 99 minutes and 30 seconds (queued for 14 seconds)
latest
Status Job ID Name Coverage
  Build
manual #34909849
allowed to fail manual
review-docs-deploy
 
  Prepare
passed #34909851
gitlab-org
retrieve-tests-metadata

00:02:02

passed #34909852
gitlab-org
setup-test-env

00:15:37

 
  Test
passed #34909946
codeclimate

00:07:47

passed #34909943
gitlab-org
db:check-schema-pg

00:04:04

passed #34909936
gitlab-org
db:migrate:reset-mysql

00:09:35

passed #34909935
gitlab-org
db:migrate:reset-pg

00:04:04

passed #34909940
gitlab-org
db:rollback-mysql

00:04:40

passed #34909939
gitlab-org
db:rollback-pg

00:05:42

passed #34909942
gitlab-org
db:seed_fu-mysql

00:04:04

passed #34909941
gitlab-org
db:seed_fu-pg

00:03:45

passed #34909930
gitlab-org
docs lint

00:01:20

passed #34909933
gitlab-org
downtime_check

00:03:40

failed #34915009
gitlab-org allowed to fail
ee_compat_check

00:14:23

passed #34909944
gitlab-org
gitlab:assets:compile

00:10:17

passed #34909947
gitlab_git_test

00:04:13

passed #34916584
gitlab-org
karma

00:10:56

50.62%
passed #34909938
gitlab-org
migration:path-mysql

00:21:34

passed #34909937
gitlab-org
migration:path-pg

00:13:54

failed #34917146
gitlab-org
rspec-mysql 0 25

00:25:38

passed #34909889
gitlab-org
rspec-mysql 1 25

00:17:41

failed #34915406
gitlab-org
rspec-mysql 10 25

00:12:36

passed #34909900
gitlab-org
rspec-mysql 11 25

00:14:38

passed #34909901
gitlab-org
rspec-mysql 12 25

00:20:01

failed #34921796
gitlab-org
rspec-mysql 13 25

00:29:07

failed #34918319
gitlab-org
rspec-mysql 14 25

00:15:31

passed #34909904
gitlab-org
rspec-mysql 15 25

00:15:41

passed #34909905
gitlab-org
rspec-mysql 16 25

00:41:28

failed #34916162
gitlab-org
rspec-mysql 17 25

00:27:49

passed #34909907
gitlab-org
rspec-mysql 18 25

00:19:02

passed #34909908
gitlab-org
rspec-mysql 19 25

00:39:52

passed #34909890
gitlab-org
rspec-mysql 2 25

00:27:39

passed #34909909
gitlab-org
rspec-mysql 20 25

00:16:45

passed #34909910
gitlab-org
rspec-mysql 21 25

00:15:30

failed #34917262
gitlab-org
rspec-mysql 22 25

00:21:17

passed #34909912
gitlab-org
rspec-mysql 23 25

00:21:55

failed #34916743
gitlab-org
rspec-mysql 24 25

00:12:37

passed #34909891
gitlab-org
rspec-mysql 3 25

00:14:07

passed #34909893
gitlab-org
rspec-mysql 4 25

00:23:50

passed #34909894
gitlab-org
rspec-mysql 5 25

00:54:42

passed #34909895
gitlab-org
rspec-mysql 6 25

00:28:54

passed #34909896
gitlab-org
rspec-mysql 7 25

00:33:53

passed #34909897
gitlab-org
rspec-mysql 8 25

00:28:07

passed #34909898
gitlab-org
rspec-mysql 9 25

00:25:28

failed #34916767
gitlab-org
rspec-pg 0 25

00:08:33

passed #34909854
gitlab-org
rspec-pg 1 25

00:13:22

failed #34917957
gitlab-org
rspec-pg 10 25

00:47:20

passed #34909874
gitlab-org
rspec-pg 11 25

00:49:36

passed #34909875
gitlab-org
rspec-pg 12 25

00:58:46

failed #34916363
gitlab-org
rspec-pg 13 25

00:14:43

failed #34917786
gitlab-org
rspec-pg 14 25

00:17:47

passed #34909878
gitlab-org
rspec-pg 15 25

00:33:41

passed #34909879
gitlab-org
rspec-pg 16 25

00:27:33

failed #34917665
gitlab-org
rspec-pg 17 25

00:14:09

passed #34909881
gitlab-org
rspec-pg 18 25

00:19:14

passed #34909882
gitlab-org
rspec-pg 19 25

00:32:15

passed #34909856
gitlab-org
rspec-pg 2 25

00:42:54

passed #34909883
gitlab-org
rspec-pg 20 25

00:16:41

passed #34909884
gitlab-org
rspec-pg 21 25

00:17:54

failed #34916761
gitlab-org
rspec-pg 22 25

00:20:15

passed #34909886
gitlab-org
rspec-pg 23 25

00:52:47

failed #34915969
gitlab-org
rspec-pg 24 25

00:13:27

passed #34909859
gitlab-org
rspec-pg 3 25

00:22:31

passed #34909861
gitlab-org
rspec-pg 4 25

00:14:49

passed #34909863
gitlab-org
rspec-pg 5 25

00:31:21

passed #34909865
gitlab-org
rspec-pg 6 25

00:13:28

passed #34909867
gitlab-org
rspec-pg 7 25

00:39:12

passed #34909869
gitlab-org
rspec-pg 8 25

00:45:45

passed #34909871
gitlab-org
rspec-pg 9 25

00:32:00

passed #34909923
gitlab-org
spinach-mysql 0 5

00:13:16

passed #34909924
gitlab-org
spinach-mysql 1 5

00:21:23

passed #34909925
gitlab-org
spinach-mysql 2 5

00:11:38

failed #34916353
gitlab-org
spinach-mysql 3 5

00:18:20

passed #34909927
gitlab-org
spinach-mysql 4 5

00:10:47

passed #34909916
gitlab-org
spinach-pg 0 5

00:12:33

passed #34909919
gitlab-org
spinach-pg 1 5

00:12:14

passed #34909920
gitlab-org
spinach-pg 2 5

00:12:28

failed #34916560
gitlab-org
spinach-pg 3 5

00:17:05

passed #34909922
gitlab-org
spinach-pg 4 5

00:13:08

failed #34916530
gitlab-org
static-analysis

00:10:04

failed #34909934
gitlab-org allowed to fail
ee_compat_check

00:10:08

failed #34909945
gitlab-org
karma

00:19:06

50.62%
failed #34909888
gitlab-org
rspec-mysql 0 25

00:24:26

failed #34909899
gitlab-org
rspec-mysql 10 25

00:13:35

failed #34909902
gitlab-org
rspec-mysql 13 25

00:53:35

failed #34909903
gitlab-org
rspec-mysql 14 25

00:31:41

failed #34909906
gitlab-org
rspec-mysql 17 25

00:16:45

failed #34909911
gitlab-org
rspec-mysql 22 25

00:25:37

failed #34909914
gitlab-org
rspec-mysql 24 25

00:20:43

failed #34909853
gitlab-org
rspec-pg 0 25

00:22:01

failed #34909873
gitlab-org
rspec-pg 10 25

00:29:15

failed #34909876
gitlab-org
rspec-pg 13 25

00:19:06

failed #34909877
gitlab-org
rspec-pg 14 25

00:27:55

failed #34909880
gitlab-org
rspec-pg 17 25

00:27:33

failed #34909885
gitlab-org
rspec-pg 22 25

00:21:27

failed #34909887
gitlab-org
rspec-pg 24 25

00:15:00

failed #34909926
gitlab-org
spinach-mysql 3 5

00:17:55

failed #34909921
gitlab-org
spinach-pg 3 5

00:19:14

failed #34909928
gitlab-org
static-analysis

00:18:44

 
  Post Test
skipped #34909949
gitlab-org
coverage
skipped #34909948
gitlab-org allowed to fail
flaky-examples-check
skipped #34909950
gitlab-org
lint:javascript:report
 
  Post Cleanup
skipped #34909951
allowed to fail manual
review-docs-cleanup
 
Name Stage Failure
failed
static-analysis Test There is an unknown failure, please try again
app/models/repository.rb:119:31: C: Layout/SpaceBeforeComma: Space found before comma.
def commits(ref, author: nil , path: nil, limit: nil, offset: nil, skip_merges: false, after: nil, before: nil)
^
lib/gitlab/project_search_results.rb:125:50: W: Lint/CircularArgumentReference: Circular argument reference - query.
def find_commits_by_message_or_author(query: query)
^^^^^

5102 files inspected, 2 offenses detected
ERROR: Job failed: exit code 1
failed
ee_compat_check Test There is an unknown failure, please try again
      ==================== THANKS FOR READING ====================
============================================================



Uploading artifacts...
ee_compat_check/patches/*.patch: found 1 matching files
Uploading artifacts to coordinator... ok id=34915009 responseStatus=201 Created token=eTtRRJaz
ERROR: Job failed: exit code 1
failed
rspec-pg 10 25 Test There is an unknown failure, please try again
rspec ./spec/features/search/user_searches_for_comments_spec.rb:36 # User searches for comments when a comment is in a snippet finds a snippet

Uploading artifacts...
coverage/: found 5 matching files
knapsack/: found 5 matching files
rspec_flaky/: found 5 matching files
tmp/capybara/: found 9 matching files
Uploading artifacts to coordinator... ok id=34917957 responseStatus=201 Created token=hsAb7S-N
ERROR: Job failed: exit code 1
failed
rspec-mysql 10 25 Test There is an unknown failure, please try again
rspec ./spec/features/search/user_searches_for_comments_spec.rb:36 # User searches for comments when a comment is in a snippet finds a snippet

Uploading artifacts...
coverage/: found 5 matching files
knapsack/: found 5 matching files
rspec_flaky/: found 5 matching files
tmp/capybara/: found 9 matching files
Uploading artifacts to coordinator... ok id=34915406 responseStatus=201 Created token=hPsX4sze
ERROR: Job failed: exit code 1
failed
rspec-pg 24 25 Test There is an unknown failure, please try again
rspec './spec/models/repository_spec.rb[1:9:1:1:2]' # Repository#find_commits_by_message_or_author when Gitaly commits_by_message feature is enabled behaves like finding commits by message is case insensitive

Uploading artifacts...
coverage/: found 5 matching files
knapsack/: found 5 matching files
rspec_flaky/: found 5 matching files
WARNING: tmp/capybara/: no matching files
Uploading artifacts to coordinator... ok id=34915969 responseStatus=201 Created token=UG8_z33h
ERROR: Job failed: exit code 1
failed
rspec-pg 0 25 Test There is an unknown failure, please try again
rspec ./spec/features/projects/commits/user_filters_commits_by_author_spec.rb:8 # User browses commits when filtering by author name filters commits by authors name

Uploading artifacts...
coverage/: found 5 matching files
knapsack/: found 5 matching files
rspec_flaky/: found 5 matching files
tmp/capybara/: found 5 matching files
Uploading artifacts to coordinator... ok id=34916767 responseStatus=201 Created token=2xzi5xzy
ERROR: Job failed: exit code 1
failed
rspec-mysql 13 25 Test There is an unknown failure, please try again
rspec ./spec/features/search/user_searches_for_commits_spec.rb:41 # User searches for commits when searching by message finds multiple commits

Uploading artifacts...
coverage/: found 5 matching files
knapsack/: found 5 matching files
rspec_flaky/: found 5 matching files
tmp/capybara/: found 13 matching files
Uploading artifacts to coordinator... ok id=34921796 responseStatus=201 Created token=fPeo7nBs
ERROR: Job failed: exit code 1
failed
rspec-mysql 14 25 Test There is an unknown failure, please try again
rspec ./spec/features/projects/files/user_searches_for_files_spec.rb:50 # User searches for files project tree screen shows found files

Uploading artifacts...
coverage/: found 5 matching files
knapsack/: found 5 matching files
rspec_flaky/: found 5 matching files
tmp/capybara/: found 7 matching files
Uploading artifacts to coordinator... ok id=34918319 responseStatus=201 Created token=xBGB6j39
ERROR: Job failed: exit code 1
failed
spinach-pg 3 5 Test There is an unknown failure, please try again
Steps Summary: (4) Successful, (0) Pending, (0) Undefined, (1) Failed, (0) Error

Finished in 63.906217702 seconds
Uploading artifacts...
coverage/: found 5 matching files
knapsack/: found 5 matching files
tmp/capybara/: found 3 matching files
Uploading artifacts to coordinator... ok id=34916560 responseStatus=201 Created token=HFBdeYaV
ERROR: Job failed: exit code 1
failed
rspec-pg 13 25 Test There is an unknown failure, please try again
rspec ./spec/features/search/user_searches_for_commits_spec.rb:41 # User searches for commits when searching by message finds multiple commits

Uploading artifacts...
coverage/: found 5 matching files
knapsack/: found 5 matching files
rspec_flaky/: found 5 matching files
tmp/capybara/: found 13 matching files
Uploading artifacts to coordinator... ok id=34916363 responseStatus=201 Created token=RygSy1zd
ERROR: Job failed: exit code 1
failed
rspec-pg 22 25 Test There is an unknown failure, please try again
rspec ./spec/features/search/user_searches_for_code_spec.rb:58 # User searches for code when signed out finds code

Uploading artifacts...
coverage/: found 5 matching files
knapsack/: found 5 matching files
rspec_flaky/: found 5 matching files
tmp/capybara/: found 17 matching files
Uploading artifacts to coordinator... ok id=34916761 responseStatus=201 Created token=cS27Ta9x
ERROR: Job failed: exit code 1
failed
rspec-mysql 17 25 Test There is an unknown failure, please try again
rspec './spec/lib/gitlab/project_search_results_spec.rb[1:8:2:4:2:2:3]' # Gitlab::ProjectSearchResults commit search by commit hash behaves like access restricted commits when project is private team access shows commit to reporter

Uploading artifacts...
coverage/: found 5 matching files
knapsack/: found 5 matching files
rspec_flaky/: found 5 matching files
WARNING: tmp/capybara/: no matching files
Uploading artifacts to coordinator... ok id=34916162 responseStatus=201 Created token=NqjUR6wf
ERROR: Job failed: exit code 1
failed
rspec-mysql 24 25 Test There is an unknown failure, please try again
rspec './spec/models/repository_spec.rb[1:9:1:1:2]' # Repository#find_commits_by_message_or_author when Gitaly commits_by_message feature is enabled behaves like finding commits by message is case insensitive

Uploading artifacts...
coverage/: found 5 matching files
knapsack/: found 5 matching files
rspec_flaky/: found 5 matching files
WARNING: tmp/capybara/: no matching files
Uploading artifacts to coordinator... ok id=34916743 responseStatus=201 Created token=uHN5DYyX
ERROR: Job failed: exit code 1
failed
spinach-mysql 3 5 Test There is an unknown failure, please try again
Steps Summary: (4) Successful, (0) Pending, (0) Undefined, (1) Failed, (0) Error

Finished in 64.09323022 seconds
Uploading artifacts...
coverage/: found 5 matching files
knapsack/: found 5 matching files
tmp/capybara/: found 3 matching files
Uploading artifacts to coordinator... ok id=34916353 responseStatus=201 Created token=ctytvRcQ
ERROR: Job failed: exit code 1
failed
rspec-pg 17 25 Test There is an unknown failure, please try again
rspec './spec/lib/gitlab/project_search_results_spec.rb[1:8:2:4:2:2:3]' # Gitlab::ProjectSearchResults commit search by commit hash behaves like access restricted commits when project is private team access shows commit to reporter

Uploading artifacts...
coverage/: found 5 matching files
knapsack/: found 5 matching files
rspec_flaky/: found 5 matching files
WARNING: tmp/capybara/: no matching files
Uploading artifacts to coordinator... ok id=34917665 responseStatus=201 Created token=1N6XzTVW
ERROR: Job failed: exit code 1
failed
rspec-pg 14 25 Test There is an unknown failure, please try again
rspec ./spec/features/projects/files/user_searches_for_files_spec.rb:50 # User searches for files project tree screen shows found files

Uploading artifacts...
coverage/: found 5 matching files
knapsack/: found 5 matching files
rspec_flaky/: found 5 matching files
tmp/capybara/: found 5 matching files
Uploading artifacts to coordinator... ok id=34917786 responseStatus=201 Created token=zUz3s2sn
ERROR: Job failed: exit code 1
failed
rspec-mysql 22 25 Test There is an unknown failure, please try again
rspec ./spec/features/search/user_searches_for_code_spec.rb:58 # User searches for code when signed out finds code

Uploading artifacts...
coverage/: found 5 matching files
knapsack/: found 5 matching files
rspec_flaky/: found 5 matching files
tmp/capybara/: found 17 matching files
Uploading artifacts to coordinator... ok id=34917262 responseStatus=201 Created token=A4m_PsiA
ERROR: Job failed: exit code 1
failed
rspec-mysql 0 25 Test There is an unknown failure, please try again
      doesn't send email to anyone but subscribers of the given labels
confidential issues
Uploading artifacts...
coverage/: found 5 matching files
knapsack/: found 5 matching files
rspec_flaky/: found 5 matching files
tmp/capybara/: found 5 matching files
Uploading artifacts to coordinator... ok id=34917146 responseStatus=201 Created token=M88bumao
ERROR: Job failed: exit code 1